feat(hubble): use fixed domain for hubble api#349
Merged
Conversation
e8e06f7 to
616fd9a
Compare
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 86.19% 86.20% +0.01%
==========================================
Files 134 134
Lines 6331 6323 -8
==========================================
- Hits 5457 5451 -6
+ Misses 874 872 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
black -S accepts single quote |
Avoid several problems caused by unstable api.jina.ai
616fd9a to
de167c1
Compare
alaeddine-13
approved these changes
May 19, 2022
alaeddine-13
left a comment
Member
There was a problem hiding this comment.
LGTM, just a small suggestion
Co-authored-by: AlaeddineAbdessalem <alaeddine-13@live.fr>
Member
|
@mapleeit I couldn't provide a suggestion that spans deleted lines, don't accept it directly xd |
Contributor
Author
|
Done! Thanks for the advice. Fancy python syntax. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
api.jina.aiis unstable sometimes, remove this layer to get better quality. We need to maintain the old domain even we move to new domain anyway, so no worries about writing domain down directly.Related to https://github.com/jina-ai/hubble/issues/434