docs: add sending section#1350
Merged
Merged
Conversation
Signed-off-by: nan-wang <nan.wang@jina.ai>
Signed-off-by: nan-wang <nan.wang@jina.ai>
Signed-off-by: nan-wang <nan.wang@jina.ai>
Signed-off-by: nan-wang <nan.wang@jina.ai>
Signed-off-by: nan-wang <nan.wang@jina.ai>
Member
|
weird that the CI is not triggered. Any idea why @nan-wang ? If you originally open the PR against the main branch and change it later to feat-rewrite-v2 then maybe you need to create a new PR it happened to me a couple of time that it messed up the CI |
samsja
reviewed
Apr 11, 2023
samsja
reviewed
Apr 11, 2023
samsja
requested changes
Apr 11, 2023
samsja
left a comment
Member
There was a problem hiding this comment.
looks good. Maybe we could point to the docstring as well ? If this does not work we can fix it later
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
1 task
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
alexcg1
previously requested changes
Apr 13, 2023
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com> Co-authored-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Co-authored-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com>
|
📝 Docs are deployed on https://ft-docs-send-doclist-0410--jina-docs.netlify.app 🎉 |
anna-charlotte
approved these changes
Apr 13, 2023
anna-charlotte
pushed a commit
that referenced
this pull request
Apr 14, 2023
* docs: add serialization for json Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for binary and protobuf Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for base64 and bytes Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for csv Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for dataframe Signed-off-by: nan-wang <nan.wang@jina.ai> * fix: add doctring to documentaion basedoc Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix mypy Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: add docstring doc list Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: dic doc array docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix page for doc list serilizaiton Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: add docvec Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * docs: add send doc section Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * docs: fix docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * refactor: better tree structure for sending Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix tests Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix python code snippet ods Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix remove breakpoint Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: add intro Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: add ref Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: move fastapi part Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix fastAPI Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: remove uselss mixin Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * faet: add jina section Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: compress -> compression Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: apply suggestion Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com> Co-authored-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> * fix: apply alex suggestion Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * wip Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix all docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix update docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix ruff Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix smth Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: apply charllote suggestion Co-authored-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> --------- Signed-off-by: nan-wang <nan.wang@jina.ai> Signed-off-by: samsja <sami.jaghouar@hotmail.fr> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: samsja <sami.jaghouar@hotmail.fr> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com> Co-authored-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai>
anna-charlotte
pushed a commit
that referenced
this pull request
Apr 14, 2023
* docs: add storing with file Signed-off-by: nan-wang <nan.wang@jina.ai> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs: add docs for the S3 store Signed-off-by: nan-wang <nan.wang@jina.ai> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs: add docs for jac store Signed-off-by: nan-wang <nan.wang@jina.ai> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs: store section in user guide Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs: add doc stores to api reference section Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs: fix docstrings Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: clean up Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: path in file doc store Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs(menu): consistency, wording fixes (#1363) * docs(menu): consistency, wording fixes Signed-off-by: Alex C-G <alexcg@outlook.com> * docs(intro): remove redundancy in title Signed-off-by: Alex C-G <alexcg@outlook.com> --------- Signed-off-by: Alex C-G <alexcg@outlook.com> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: default dims=-1 for elastic index (#1368) Signed-off-by: AnneY <evangeline-lun@foxmail.com> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: s3 bucket var Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: typo and s3 delete code snippet Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs: exclude jacdocstore docs from test for now Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * Revert "docs: exclude jacdocstore docs from test for now" This reverts commit a52fed5. Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs: exclude jac tests Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * feat: weaviate document index V2! (#1367) Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs: add sending section (#1350) * docs: add serialization for json Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for binary and protobuf Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for base64 and bytes Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for csv Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for dataframe Signed-off-by: nan-wang <nan.wang@jina.ai> * fix: add doctring to documentaion basedoc Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix mypy Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: add docstring doc list Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: dic doc array docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix page for doc list serilizaiton Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: add docvec Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * docs: add send doc section Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * docs: fix docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * refactor: better tree structure for sending Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix tests Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix python code snippet ods Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix remove breakpoint Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: add intro Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: add ref Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: move fastapi part Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix fastAPI Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: remove uselss mixin Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * faet: add jina section Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: compress -> compression Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: apply suggestion Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com> Co-authored-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> * fix: apply alex suggestion Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * wip Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix all docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix update docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix ruff Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix smth Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: apply charllote suggestion Co-authored-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> --------- Signed-off-by: nan-wang <nan.wang@jina.ai> Signed-off-by: samsja <sami.jaghouar@hotmail.fr> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: samsja <sami.jaghouar@hotmail.fr> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com> Co-authored-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> * fix: apply sami suggestion Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: apply suggestions from samis code review Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * docs: add missing links and clean up (#1370) * docs: add links and clean up Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: Text to TextDoc Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: 3d urls Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: pc url Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: comment out display pc Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> --------- Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> --------- Signed-off-by: nan-wang <nan.wang@jina.ai> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> Signed-off-by: Alex C-G <alexcg@outlook.com> Signed-off-by: AnneY <evangeline-lun@foxmail.com> Signed-off-by: samsja <sami.jaghouar@hotmail.fr> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> Co-authored-by: anna-charlotte <charlotte.gerhaher@jina.ai> Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com> Co-authored-by: Anne Yang <evangeline-lun@foxmail.com> Co-authored-by: Shukri <hsm207@users.noreply.github.com> Co-authored-by: samsja <sami.jaghouar@hotmail.fr> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR do