docs: add storing with file#1348
Merged
Merged
Conversation
Contributor
|
hey @nan-wang do you mind if I take over this PR? |
e2427c4 to
dfae816
Compare
9254472 to
a75f7a1
Compare
samsja
reviewed
Apr 14, 2023
samsja
requested changes
Apr 14, 2023
samsja
left a comment
Member
There was a problem hiding this comment.
Looks really good ! .
on comment, can we put the three docs about push pull into a common folder ? So that we have distinction between DocStore and DocIndex 
Signed-off-by: nan-wang <nan.wang@jina.ai> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: nan-wang <nan.wang@jina.ai> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: nan-wang <nan.wang@jina.ai> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
* docs(menu): consistency, wording fixes Signed-off-by: Alex C-G <alexcg@outlook.com> * docs(intro): remove redundancy in title Signed-off-by: Alex C-G <alexcg@outlook.com> --------- Signed-off-by: Alex C-G <alexcg@outlook.com> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: AnneY <evangeline-lun@foxmail.com> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
This reverts commit a52fed5. Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
* docs: add serialization for json Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for binary and protobuf Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for base64 and bytes Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for csv Signed-off-by: nan-wang <nan.wang@jina.ai> * docs: add serialization for dataframe Signed-off-by: nan-wang <nan.wang@jina.ai> * fix: add doctring to documentaion basedoc Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix mypy Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: add docstring doc list Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: dic doc array docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix page for doc list serilizaiton Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: add docvec Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * docs: add send doc section Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * docs: fix docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * refactor: better tree structure for sending Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix tests Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix python code snippet ods Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix remove breakpoint Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: add intro Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: add ref Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: move fastapi part Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix fastAPI Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: remove uselss mixin Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * faet: add jina section Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: compress -> compression Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: apply suggestion Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com> Co-authored-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> * fix: apply alex suggestion Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * wip Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix all docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix update docstring Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix ruff Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * fix: fix smth Signed-off-by: samsja <sami.jaghouar@hotmail.fr> * feat: apply charllote suggestion Co-authored-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> --------- Signed-off-by: nan-wang <nan.wang@jina.ai> Signed-off-by: samsja <sami.jaghouar@hotmail.fr> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: samsja <sami.jaghouar@hotmail.fr> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com> Co-authored-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai>
Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
* docs: add links and clean up Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: Text to TextDoc Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: 3d urls Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: pc url Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> * fix: comment out display pc Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai> --------- Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
7097f98 to
597cd3a
Compare
…-0409 Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
|
📝 Docs are deployed on https://ft-docs-store-0409--jina-docs.netlify.app 🎉 |
samsja
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals: