fix(button): dont render double icons on icon-only-button when loading#4023
Merged
fix(button): dont render double icons on icon-only-button when loading#4023
Conversation
🦋 Changeset detectedLatest commit: bfe2170 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Preview deployments for this pull request: storybook - |
Member
|
Thanks for the PR. We will discuss the best solution to this internally, and comment a decision in the issue |
Barsnes
requested changes
Sep 29, 2025
Member
Barsnes
left a comment
There was a problem hiding this comment.
Can you update the jsdoc as well?
An example in Storybook would also be nice, the one we have does not have an icon button
Barsnes
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Icon-only buttons appear visually cluttered when both the icon and loading spinner are set to true. To improve clarity, remove the icon when loading is true so only the spinner is displayed. This does not affect assistive technology, as icon-only buttons should always include an appropriate
aria-label.resolves #4041
Checks
pnpm changesetif relevant)