Skip to content

<Button icon loading> renders outside of button #4041

@Barsnes

Description

@Barsnes

Version number

1.4.0

Description of the bug

This was first reported on slack, and we got #4023 from @stianmorsund as well.

Image

We had a brief discussion about this, but no action has been taken yet.
This might be up to the user to decide.

We can either remove the icon, or let it be up to the user to do this. It's simple enough for us to do it for out icon button, but it's harder for a normal button

Aksel removes all other content:

Image

Steps To Reproduce

  1. use <Button icon loading><Icon /></Button>

Additional Information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    🐛 bugSomething isn't working

    Type

    No type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions