css_ast: Implement Background property - #1131
Merged
Merged
Conversation
keithamus
enabled auto-merge (squash)
May 18, 2026 21:24
This change touches a few things: - background is awkwardly defined as `<bg-layer>#? , <final-bg-layer>`. The only difference is the trailing `<color>`. We simplify this to just `<bg-layer>`, we can do the validation at some other point, to ensure multiple colours aren't used. - This simplification requires a `value_replacements` system, on top o `value_extensions`, these should probably be consolidated somehow at some point... - This has many dependant types, so this change implements all of those.
keithamus
force-pushed
the
css-ast-implement-background-property
branch
from
May 18, 2026 21:34
81ee2b6 to
9025d20
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
May 20, 2026
## [0.0.23] - 2026-05-20 ### Other Changes - Coverage: update css-minify-tests (#1133) ([#1133](#1133)) ### Css_ast - fix(css_parse): preserve whitespace around +/- in calc() (#1114) ([#1114](#1114)) - coverage: drop bootstrap/foundation .min files (#1117) ([#1117](#1117)) - css_ast: Implement relative color syntax (#1119) ([#1119](#1119)) - Regenerate css_ast/src/values from csswg drafts (#1120) ([#1120](#1120)) - csskit_spec_generator/css_ast: Generate properties from SVG, PointerEvents specs (#1121) ([#1121](#1121)) - css_ast: Implement ContentStyleValue (#1122) ([#1122](#1122)) - Regenerate css_ast/src/values from csswg drafts (#1123) ([#1123](#1123)) - css_ast: add pinch-zoom to touch-action (#1128) ([#1128](#1128)) - css_ast/csskit: Finish off ToSpecificity, add `csskit specificity` command (#1129) ([#1129](#1129)) - css_ast: Box all Gradient types (#1130) ([#1130](#1130)) - css_ast: Implement Background property (#1131) ([#1131](#1131)) - css_ast: Implement SpreadShadow, improve Shadow (#1132) ([#1132](#1132)) ### Css_lexer - css_parse: refactor CursorCompactWriteSink, preserve comments between idents (#1118) ([#1118](#1118)) ### Csskit - chore(deps): update dependencies (patch) (#1124) ([#1124](#1124)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.64.0 (#1127) ([#1127](#1127)) - chore(deps): update dependency @types/vscode to v1.120.0 (#1125) ([#1125](#1125)) [forcebuild]
Merged
github-actions Bot
pushed a commit
that referenced
this pull request
May 20, 2026
## [0.0.23] - 2026-05-20 ### Other Changes - Coverage: update css-minify-tests (#1133) ([#1133](#1133)) ### Css_ast - fix(css_parse): preserve whitespace around +/- in calc() (#1114) ([#1114](#1114)) - coverage: drop bootstrap/foundation .min files (#1117) ([#1117](#1117)) - css_ast: Implement relative color syntax (#1119) ([#1119](#1119)) - Regenerate css_ast/src/values from csswg drafts (#1120) ([#1120](#1120)) - csskit_spec_generator/css_ast: Generate properties from SVG, PointerEvents specs (#1121) ([#1121](#1121)) - css_ast: Implement ContentStyleValue (#1122) ([#1122](#1122)) - Regenerate css_ast/src/values from csswg drafts (#1123) ([#1123](#1123)) - css_ast: add pinch-zoom to touch-action (#1128) ([#1128](#1128)) - css_ast/csskit: Finish off ToSpecificity, add `csskit specificity` command (#1129) ([#1129](#1129)) - css_ast: Box all Gradient types (#1130) ([#1130](#1130)) - css_ast: Implement Background property (#1131) ([#1131](#1131)) - css_ast: Implement SpreadShadow, improve Shadow (#1132) ([#1132](#1132)) ### Css_lexer - css_parse: refactor CursorCompactWriteSink, preserve comments between idents (#1118) ([#1118](#1118)) ### Csskit - chore(deps): update dependencies (patch) (#1124) ([#1124](#1124)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.64.0 (#1127) ([#1127](#1127)) - chore(deps): update dependency @types/vscode to v1.120.0 (#1125) ([#1125](#1125))
github-actions Bot
pushed a commit
that referenced
this pull request
May 21, 2026
## [0.0.23] - 2026-05-21 ### Other Changes - Coverage: update css-minify-tests (#1133) ([#1133](#1133)) ### Css_ast - fix(css_parse): preserve whitespace around +/- in calc() (#1114) ([#1114](#1114)) - coverage: drop bootstrap/foundation .min files (#1117) ([#1117](#1117)) - css_ast: Implement relative color syntax (#1119) ([#1119](#1119)) - Regenerate css_ast/src/values from csswg drafts (#1120) ([#1120](#1120)) - csskit_spec_generator/css_ast: Generate properties from SVG, PointerEvents specs (#1121) ([#1121](#1121)) - css_ast: Implement ContentStyleValue (#1122) ([#1122](#1122)) - Regenerate css_ast/src/values from csswg drafts (#1123) ([#1123](#1123)) - css_ast: add pinch-zoom to touch-action (#1128) ([#1128](#1128)) - css_ast/csskit: Finish off ToSpecificity, add `csskit specificity` command (#1129) ([#1129](#1129)) - css_ast: Box all Gradient types (#1130) ([#1130](#1130)) - css_ast: Implement Background property (#1131) ([#1131](#1131)) - css_ast: Implement SpreadShadow, improve Shadow (#1132) ([#1132](#1132)) - css_ast: Implement text-overflow (#1134) ([#1134](#1134)) - css_ast: Implement more legacy/vendor display values (#1135) ([#1135](#1135)) ### Css_lexer - css_parse: refactor CursorCompactWriteSink, preserve comments between idents (#1118) ([#1118](#1118)) ### Csskit - chore(deps): update dependencies (patch) (#1124) ([#1124](#1124)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.64.0 (#1127) ([#1127](#1127)) - chore(deps): update dependency @types/vscode to v1.120.0 (#1125) ([#1125](#1125)) [forcebuild]
github-actions Bot
pushed a commit
that referenced
this pull request
May 21, 2026
## [0.0.23] - 2026-05-21 ### Other Changes - Coverage: update css-minify-tests (#1133) ([#1133](#1133)) ### Css_ast - fix(css_parse): preserve whitespace around +/- in calc() (#1114) ([#1114](#1114)) - coverage: drop bootstrap/foundation .min files (#1117) ([#1117](#1117)) - css_ast: Implement relative color syntax (#1119) ([#1119](#1119)) - Regenerate css_ast/src/values from csswg drafts (#1120) ([#1120](#1120)) - csskit_spec_generator/css_ast: Generate properties from SVG, PointerEvents specs (#1121) ([#1121](#1121)) - css_ast: Implement ContentStyleValue (#1122) ([#1122](#1122)) - Regenerate css_ast/src/values from csswg drafts (#1123) ([#1123](#1123)) - css_ast: add pinch-zoom to touch-action (#1128) ([#1128](#1128)) - css_ast/csskit: Finish off ToSpecificity, add `csskit specificity` command (#1129) ([#1129](#1129)) - css_ast: Box all Gradient types (#1130) ([#1130](#1130)) - css_ast: Implement Background property (#1131) ([#1131](#1131)) - css_ast: Implement SpreadShadow, improve Shadow (#1132) ([#1132](#1132)) - css_ast: Implement text-overflow (#1134) ([#1134](#1134)) - css_ast: Implement more legacy/vendor display values (#1135) ([#1135](#1135)) ### Css_lexer - css_parse: refactor CursorCompactWriteSink, preserve comments between idents (#1118) ([#1118](#1118)) ### Csskit - chore(deps): update dependencies (patch) (#1124) ([#1124](#1124)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.64.0 (#1127) ([#1127](#1127)) - chore(deps): update dependency @types/vscode to v1.120.0 (#1125) ([#1125](#1125))
github-actions Bot
pushed a commit
that referenced
this pull request
May 22, 2026
## [0.0.23] - 2026-05-22 ### Other Changes - Coverage: update css-minify-tests (#1133) ([#1133](#1133)) ### Css_ast - fix(css_parse): preserve whitespace around +/- in calc() (#1114) ([#1114](#1114)) - coverage: drop bootstrap/foundation .min files (#1117) ([#1117](#1117)) - css_ast: Implement relative color syntax (#1119) ([#1119](#1119)) - Regenerate css_ast/src/values from csswg drafts (#1120) ([#1120](#1120)) - csskit_spec_generator/css_ast: Generate properties from SVG, PointerEvents specs (#1121) ([#1121](#1121)) - css_ast: Implement ContentStyleValue (#1122) ([#1122](#1122)) - Regenerate css_ast/src/values from csswg drafts (#1123) ([#1123](#1123)) - css_ast: add pinch-zoom to touch-action (#1128) ([#1128](#1128)) - css_ast/csskit: Finish off ToSpecificity, add `csskit specificity` command (#1129) ([#1129](#1129)) - css_ast: Box all Gradient types (#1130) ([#1130](#1130)) - css_ast: Implement Background property (#1131) ([#1131](#1131)) - css_ast: Implement SpreadShadow, improve Shadow (#1132) ([#1132](#1132)) - css_ast: Implement text-overflow (#1134) ([#1134](#1134)) - css_ast: Implement more legacy/vendor display values (#1135) ([#1135](#1135)) - css_ast: Implement light-dark for color values (#1136) ([#1136](#1136)) ### Css_lexer - css_parse: refactor CursorCompactWriteSink, preserve comments between idents (#1118) ([#1118](#1118)) ### Csskit - chore(deps): update dependencies (patch) (#1124) ([#1124](#1124)) ### Csskit_spec_generator - csskit_spec_generator: Replace non-breaking spaces with whitespace (#1137) ([#1137](#1137)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.64.0 (#1127) ([#1127](#1127)) - chore(deps): update dependency @types/vscode to v1.120.0 (#1125) ([#1125](#1125)) [forcebuild]
github-actions Bot
pushed a commit
that referenced
this pull request
May 22, 2026
## [0.0.23] - 2026-05-22 ### Other Changes - Coverage: update css-minify-tests (#1133) ([#1133](#1133)) ### Css_ast - fix(css_parse): preserve whitespace around +/- in calc() (#1114) ([#1114](#1114)) - coverage: drop bootstrap/foundation .min files (#1117) ([#1117](#1117)) - css_ast: Implement relative color syntax (#1119) ([#1119](#1119)) - Regenerate css_ast/src/values from csswg drafts (#1120) ([#1120](#1120)) - csskit_spec_generator/css_ast: Generate properties from SVG, PointerEvents specs (#1121) ([#1121](#1121)) - css_ast: Implement ContentStyleValue (#1122) ([#1122](#1122)) - Regenerate css_ast/src/values from csswg drafts (#1123) ([#1123](#1123)) - css_ast: add pinch-zoom to touch-action (#1128) ([#1128](#1128)) - css_ast/csskit: Finish off ToSpecificity, add `csskit specificity` command (#1129) ([#1129](#1129)) - css_ast: Box all Gradient types (#1130) ([#1130](#1130)) - css_ast: Implement Background property (#1131) ([#1131](#1131)) - css_ast: Implement SpreadShadow, improve Shadow (#1132) ([#1132](#1132)) - css_ast: Implement text-overflow (#1134) ([#1134](#1134)) - css_ast: Implement more legacy/vendor display values (#1135) ([#1135](#1135)) - css_ast: Implement light-dark for color values (#1136) ([#1136](#1136)) ### Css_lexer - css_parse: refactor CursorCompactWriteSink, preserve comments between idents (#1118) ([#1118](#1118)) ### Csskit - chore(deps): update dependencies (patch) (#1124) ([#1124](#1124)) ### Csskit_spec_generator - csskit_spec_generator: Replace non-breaking spaces with whitespace (#1137) ([#1137](#1137)) ### Csskit_vscode - chore(deps): update dependency oxlint to v1.64.0 (#1127) ([#1127](#1127)) - chore(deps): update dependency @types/vscode to v1.120.0 (#1125) ([#1125](#1125))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change touches a few things:
<bg-layer>#? , <final-bg-layer>. The only difference is the trailing<color>.We simplify this to just
<bg-layer>, we can do the validation at some other point, to ensure multiple coloursaren't used.
value_replacementssystem, on top ovalue_extensions, these should probably beconsolidated somehow at some point...