test: add golden file test for ConvertState #20832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
golden file test is to prevent regressions in behavior. It is going to be used as a benchmark for a refactor
d879360 to
18fa1ff
Compare
6849ee9 to
7cbbc20
Compare
57ea109 to
2ee6b40
Compare
| // If the directory is missing these files, we cannot run ConvertState | ||
| // on it. So it's skipped. | ||
| if srcIdc == -1 || dotIdx == -1 { | ||
| continue |
Contributor
There was a problem hiding this comment.
This should log indicating so.
dannykopping
approved these changes
Nov 21, 2025
Contributor
dannykopping
left a comment
There was a problem hiding this comment.
LGTM, with a couple small nits
I don't need to review again
Thanks a lot for adding these!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring
ConvertStateis something we should eventually do. This PR adds a golden file unit test for the output ofConvertState(even errors).That way if a refactor occurs, we can verify the output is unchanged for our test cases.