chore: refactor ConvertState #20833
Closed
chore: refactor ConvertState #20833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golden file test is to prevent regressions in behavior. It is going to be used as a benchmark for a refactor
This reverts commit 18fa1ff.
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c59347a to
776d072
Compare
776d072 to
e69b729
Compare
6849ee9 to
7cbbc20
Compare
8a17e17 to
743e3b8
Compare
Done 100% with Claude 4.5 in mux
The graph is required for daily cost information
743e3b8 to
41c6890
Compare
57ea109 to
2ee6b40
Compare
Member
Author
|
AI did pretty good, but I'm not sure this is really any better. The state being held in a struct just means you never know what values are populated and what is not. So very error prone still. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.