Add explicit signal subscriptions to `component()` renders by Copilot · Pull Request #60 · bQuery/bQuery

Copilot · 2026-03-13T11:16:10Z

component() could read reactive values during render(), but those reads were one-shot and never drove future updates. This change adds an explicit bridge between the component and reactive modules so components can declare external reactive sources and re-render when those sources change.

New component API
- Adds signals to ComponentDefinition.
- Extends ComponentRenderContext with typed signals so render functions can consume declared reactive sources directly.
Reactive lifecycle wiring
- Subscribes component instances to declared signals/computeds via the existing reactive effect() mechanism.
- Triggers normal component update renders when subscribed sources change.
- Disposes subscriptions on disconnect and re-establishes them on reconnect.
- Re-syncs markup on reconnect so detached components reflect signal changes that happened while disconnected.
Explicit subscription boundary
- Only sources declared in signals drive re-renders.
- Signal-triggered renders run under untrack() so incidental signal reads inside render() do not create implicit subscriptions.
Coverage
- Adds focused component tests for:
  - direct signal-driven re-rendering
  - computed-driven re-rendering
  - explicit-only subscription behavior
  - reconnect synchronization

const theme = signal<'light' | 'dark'>('light');

component('my-comp', {
  signals: { theme },
  render({ signals }) {
    return html`<div class="${signals.theme.value}">...</div>`;
  },
});

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

tests/component.test.ts

Copilot

Pull request overview

Adds an explicit, typed subscription boundary between the component() Web Component system and the reactive module so components can declare external reactive sources (signals) that drive re-renders via effect(), including reconnect resubscription/sync behavior.

Changes:

Extends ComponentDefinition/ComponentRenderContext with signals and introduces ComponentSignalLike/ComponentSignals types.
Wires component instances to re-render on declared signal/computed changes using effect() + untrack(), with cleanup on disconnect and resubscribe on reconnect.
Adds component tests covering signal-driven updates, computed-driven updates, explicit-only subscription behavior, and reconnect synchronization.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`src/component/component.ts`	Adds reactive effect subscription lifecycle to trigger component re-renders from declared signals and dispose/resubscribe across connect/disconnect.
`src/component/types.ts`	Introduces signal-related types and threads `signals` through the render context and component definition generics.
`src/component/index.ts`	Re-exports the new signal-related component types from the component module entrypoint.
`tests/component.test.ts`	Adds tests validating signal/computed re-rendering, explicit subscription boundaries, and reconnect resync behavior.

src/component/component.ts

src/component/index.ts

…nent Signed-off-by: Jonas Pfalzgraf <info@josunlp.de>

JosunLP · 2026-03-13T18:53:56Z

@copilot apply changes based on the comments in this thread

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot · 2026-03-13T19:01:26Z

@copilot apply changes based on the comments in this thread

Applied the requested review-thread fixes in c9d7ec8: connectedCallback() now only defers the initial mount when required props are missing, declared signal subscriptions resume correctly after reconnect, and the new component signal types are re-exported from src/full.ts. I also added a regression test for reconnecting after a required prop is temporarily removed, and re-ran npx bun run test:types, npx bun run lint:types, npx bun test, npx bun run build, plus review and CodeQL checks.

Copilot

Pull request overview

This PR adds an explicit bridge between the component and reactive modules so Web Components defined via component() can declare external reactive sources and automatically re-render when those sources change.

Changes:

Adds signals to ComponentDefinition and exposes typed signals on ComponentRenderContext.
Wires component instances to declared reactive sources via effect(), re-rendering on updates and cleaning up on disconnect/reconnect.
Adds component tests covering signal/computed-driven re-rendering, explicit-only subscriptions, and reconnect synchronization.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/component.test.ts	Adds new tests validating re-render behavior driven by declared signals/computeds and reconnect resubscription behavior.
src/component/types.ts	Introduces `ComponentSignalLike`, `ComponentSignals`, and extends render context/definition generics to include typed `signals`.
src/component/component.ts	Subscribes to declared signals via `effect()`, triggers re-renders under `untrack()`, and disposes/restores subscriptions on disconnect/reconnect.
src/component/index.ts	Re-exports newly added public component signal-related types.
src/full.ts	Adds the new component signal-related types to the full/CDN entrypoint exports.

src/component/types.ts

src/component/component.ts

JosunLP · 2026-03-13T19:36:17Z

@copilot apply changes based on the comments in this thread

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot · 2026-03-13T19:42:21Z

@copilot apply changes based on the comments in this thread

Applied the follow-up fixes in 6910e00: non-empty typed signals now require a matching runtime signals object on ComponentDefinition, and empty signals maps now skip subscription setup so reconnects do not create no-op effect renders. Added focused type/runtime regressions and re-ran npx bun test tests/component.test.ts, npx bun run test:types, npx bun run lint:types, npx bun test, plus npx bun run build. No UI changes in this PR, so there isn’t a screenshot to attach.

Copilot

Pull request overview

This PR adds an explicit integration point between the component and reactive modules so Web Components can declare which external reactive sources (signals/computeds) should drive re-renders, instead of relying on incidental reads during render().

Changes:

Introduces signals on ComponentDefinition and threads typed signals through ComponentRenderContext.
Wires component instances to declared reactive sources via effect(), re-rendering on changes and cleaning up on disconnect/reconnect.
Adds tests covering signal/computed re-rendering, explicit-only subscriptions, and reconnect synchronization.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/component/types.ts`	Adds `ComponentSignalLike`, `ComponentSignals`, and extends component typing to include `signals` in the definition + render context.
`src/component/component.ts`	Subscribes to declared signals via `effect()` and triggers update renders under `untrack()`; cleans up subscriptions on disconnect and restores on reconnect.
`tests/component.test.ts`	Adds type-level and runtime tests for signal-driven rendering and reconnect behavior.
`src/component/index.ts`	Re-exports new public types from the component module entrypoint.
`src/full.ts`	Re-exports new component types from the full/CDN entrypoint.

src/component/component.ts

tests/component.test.ts

JosunLP · 2026-03-13T20:00:49Z

@copilot apply changes based on the comments in this thread

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot · 2026-03-13T20:05:18Z

@copilot apply changes based on the comments in this thread

Erledigt in 7b29f98. Beim Reconnect ruft connectedCallback() jetzt den User-connected-Hook erneut auf, Fehler beim Lesen deklarierter Signalquellen laufen über handleError()/onError, und der betroffene Reconnect-Test räumt das erneut angehängte Element am Ende auf. Zusätzlich habe ich Regressionstests für Reconnect-Lifecycle und Signal-Fehlerpfad ergänzt. Validiert mit npx eslint ., npx bun test, npx bun run build, npx bun run test:types und npx bun run lint:types. Keine UI-Änderung, daher kein Screenshot.

Copilot

Pull request overview

This PR adds an explicit, typed “signals” subscription bridge between the component system and the reactive module so components can re-render when declared external reactive sources change (without implicitly subscribing to incidental reads during render()).

Changes:

Adds signals typing to ComponentDefinition and exposes typed signals on ComponentRenderContext.
Wires component instances to declared signal/computed sources via effect() and uses untrack() for signal-driven renders.
Adds component tests covering signal/computed-driven re-rendering, explicit-only subscription behavior, reconnect sync, and error routing.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/component/types.ts`	Introduces `ComponentSignalLike`/`ComponentSignals` and extends component definition/render context generics to include typed signals.
`src/component/component.ts`	Implements runtime signal subscription setup/teardown using `effect()` + `untrack()`, including reconnect resubscription logic.
`tests/component.test.ts`	Adds runtime and type-level tests validating re-render behavior, explicit subscription boundaries, reconnect behavior, and error routing.
`src/component/index.ts`	Re-exports new public component signal-related types.
`src/full.ts`	Exposes the new component signal-related types in the full/CDN entrypoint.

src/component/types.ts

src/component/component.ts

JosunLP · 2026-03-13T21:02:46Z

@copilot apply changes based on the comments in this thread

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot · 2026-03-13T21:06:09Z

@copilot apply changes based on the comments in this thread

Erledigt in 3fe00bc. Die JSDoc für ComponentSignalLike und ComponentRenderContext ist jetzt korrekt zugeordnet, und beim Reconnect werden Signal-Subscriptions auch dann wiederhergestellt, wenn der User-connected-Hook einen Fehler wirft. Dazu gibt es einen Regressions-Test, der bestätigt, dass onError den Reconnect-Fehler erhält und spätere Signal-Updates trotzdem weiter rendern. Validiert mit npx bun test tests/component.test.ts, npx bun run test:types, npx bun run lint:types, npx eslint ., npx bun test und npx bun run build. Keine UI-Änderung, daher kein Screenshot.

Copilot

Pull request overview

This PR adds an explicit integration point between the component system and the reactive module so components can declare external reactive sources (signals) and automatically re-render when those sources change, including resubscribing and resyncing on reconnect.

Changes:

Extends component typings with ComponentSignalLike, ComponentSignals, and a signals field on ComponentRenderContext, plus a new TSignals generic on ComponentDefinition.
Wires component instances to reactive effect() subscriptions for declared signals, with cleanup on disconnect and resubscribe/resync on reconnect (under untrack() to prevent implicit subscriptions from render()).
Adds component tests covering signal/computed-driven re-rendering, explicit-only subscription behavior, reconnect behavior, and error routing via onError.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`src/component/types.ts`	Introduces the public `signals` typing surface area (signal-like types, render context extension, generic enforcement).
`src/component/component.ts`	Implements runtime subscription lifecycle via `effect()`/cleanup and passes `signals` into render context.
`src/component/index.ts`	Re-exports the new public component signal types.
`src/full.ts`	Exposes the new component signal types from the full/CDN entrypoint.
`tests/component.test.ts`	Adds test coverage for signal/computed re-rendering, explicit-only subscription boundary, reconnect resync, and error handling.

src/component/component.ts

JosunLP · 2026-03-13T21:19:06Z

@copilot apply changes based on the comments in this thread

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot · 2026-03-13T21:23:01Z

@copilot apply changes based on the comments in this thread

Erledigt in b783a30. Signal-getriebene Re-Renders und Reconnect-Resyncs umgehen beforeUpdate jetzt gezielt, damit identische old/new props legitime Signal-Updates nicht mehr blockieren; normale prop-/attribute-getriebene Updates behalten das bisherige beforeUpdate-Verhalten. Dazu gibt es einen Regressions-Test, der genau diesen Fall abdeckt. Validiert mit npx bun test tests/component.test.ts, npx bun run test:types, npx bun run lint:types, npx eslint ., npx bun test und npx bun run build. Keine UI-Änderung, daher kein Screenshot.

Copilot

Pull request overview

This pull request adds an explicit, typed integration point between the component() module and the reactive module so Web Components can subscribe to declared external reactive sources and re-render when those sources change (without creating implicit subscriptions from incidental reads during render()).

Changes:

Introduces signals on ComponentDefinition plus ComponentSignalLike/ComponentSignals types, and adds signals to ComponentRenderContext.
Wires component instances to re-render on declared signal/computed changes via effect(), with teardown on disconnect and resubscription + resync on reconnect (renders run under untrack()).
Expands component tests to cover signal-driven re-renders, computed support, explicit-only subscription behavior, reconnect syncing, and error routing.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`src/component/types.ts`	Adds signal-related public types and threads typed `signals` into component definition/context generics.
`src/component/component.ts`	Implements runtime subscription lifecycle (effect/untrack), reconnect behavior, and passes `signals` into render context.
`src/component/index.ts`	Re-exports new public signal-related component types.
`src/full.ts`	Keeps the full/CDN entrypoint type exports in sync with the component module.
`tests/component.test.ts`	Adds coverage for signal/computed-driven renders, explicit subscription boundary, reconnect behavior, and error handling.

* Add `bool()` support for boolean attributes in component templates (#55) Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Add typed state generics to component definitions (#56) Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Pass attribute change metadata to component `updated()` hooks (#58) Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Add per-component sanitizer overrides for component render output (#57) * Initial plan * feat: add per-component sanitizer options Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: clarify component sanitizer baseline Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: warn about sensitive component sanitizer opts Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * test: cover sanitizer allowTags overrides Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * perf: precompute component sanitizer allowlists Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Pass previous props into component `beforeUpdate` (#59) * Initial plan * Add previous props to beforeUpdate hook Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Refine beforeUpdate old props implementation Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Fix beforeUpdate typing regressions Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Add explicit signal subscriptions to `component()` renders (#60) * Initial plan * feat: add component signal subscriptions Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * chore: document signal subscription tracking Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: address signal integration review feedback Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: tighten component signal typing Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: resolve eslint failure in component signal test Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: handle reconnect lifecycle and signal effect errors Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: preserve reconnect signal wiring after hook errors Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: skip beforeUpdate for signal rerenders Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Add trusted sanitized fragments for `safeHtml` composition (#61) * Initial plan * feat: add trusted safeHtml fragment support Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * chore: finalize trusted safeHtml support Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: address trusted safeHtml review feedback Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: fix second trusted safeHtml review follow-up Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * refactor: split trusted html helpers from sanitizer Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * refactor: tighten trusted html branding Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: tighten trusted html internals Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Reuse component shadow-root style nodes across re-renders (#62) * Initial plan * fix: reuse component style element on rerender Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * chore: finalize component style reuse fix Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * test: tighten style reuse regression assertions Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Add `@bquery/bquery/storybook` template helpers for Storybook stories (#63) * Initial plan * feat: add storybook template helper Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: clarify storybook when fallback behavior Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: keep storybook helpers out of full bundle Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: sanitize storybook helper output Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * test: tighten storybook helper security coverage Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * feat: enhance storyHtml with improved boolean attribute handling and sanitization tests * fix: update storyHtml example to reflect correct boolean attribute output * fix: defensive tag delimiter and parser comments per code review Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * chore: release version 1.6.0 - Update CHANGELOG.md for version 1.6.0 release notes including added features, changes, fixes, and security improvements. - Enhance README.md to document new boolean attribute helpers and Storybook integration. - Update bun.lock to reflect dependency upgrades for Storybook and happy-dom. - Modify definition.md to include new Storybook helpers and component state management features. - Revise components.md to demonstrate new boolean attribute handling and typed state in components. - Update getting-started.md with Storybook authoring examples and improved module descriptions. - Enhance security.md to clarify sanitization practices and introduce trusted fragment handling. - Revise index.md to highlight new Storybook helpers in the feature list. - Update llms.txt to reflect the new version 1.6.0. - Bump version in package.json to 1.6.0 and update devDependencies for Storybook. * Address review feedback for test setup, test type coverage, and component state keys (#65) * Initial plan * Address review feedback for test typing and setup Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Finalize review feedback fixes Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Export component state key type Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Default component state key generic Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Tighten component/state update semantics and Storybook attribute sanitization (#66) * Initial plan * fix review follow-up for state updates and storybook sanitization Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix storybook attribute value scanning Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix storybook interpolation boundary parsing Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs align storybook attribute scan jsdoc Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Initial plan * feat: add component signal subscriptions Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * chore: document signal subscription tracking Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: address signal integration review feedback Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: tighten component signal typing Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: resolve eslint failure in component signal test Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: handle reconnect lifecycle and signal effect errors Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: preserve reconnect signal wiring after hook errors Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: skip beforeUpdate for signal rerenders Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de>

Initial plan

c3ef303

Copilot AI assigned Copilot and JosunLP Mar 13, 2026

Copilot started work on behalf of JosunLP March 13, 2026 11:20 View session

Copilot AI and others added 2 commits March 13, 2026 11:25

feat: add component signal subscriptions

0c48c30

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

chore: document signal subscription tracking

b78181c

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add signal integration in component()~~ Add explicit signal subscriptions to component() renders Mar 13, 2026

Copilot AI requested a review from JosunLP March 13, 2026 11:30

Copilot finished work on behalf of JosunLP March 13, 2026 11:30

JosunLP marked this pull request as ready for review March 13, 2026 11:38

Copilot AI review requested due to automatic review settings March 13, 2026 11:38

github-actions bot added component Changes to the component module tests Chenges to the tests labels Mar 13, 2026

github-advanced-security bot found potential problems Mar 13, 2026

View reviewed changes

tests/component.test.ts Fixed Show fixed Hide fixed

tests/component.test.ts Fixed Show fixed Hide fixed

tests/component.test.ts Fixed Show fixed Hide fixed

Copilot started reviewing on behalf of JosunLP March 13, 2026 11:38 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/component/component.ts Outdated Show resolved Hide resolved

src/component/index.ts Show resolved Hide resolved

Merge branch 'development' into copilot/fr-6-signal-integration-compo…

17a40e0

…nent Signed-off-by: Jonas Pfalzgraf <info@josunlp.de>

Copilot started work on behalf of JosunLP March 13, 2026 18:54 View session

fix: address signal integration review feedback

c9d7ec8

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot finished work on behalf of JosunLP March 13, 2026 19:01

JosunLP requested a review from Copilot March 13, 2026 19:06

Copilot started reviewing on behalf of JosunLP March 13, 2026 19:07 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/component/types.ts Outdated Show resolved Hide resolved

src/component/component.ts Outdated Show resolved Hide resolved

Copilot started work on behalf of JosunLP March 13, 2026 19:36 View session

fix: tighten component signal typing

6910e00

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot finished work on behalf of JosunLP March 13, 2026 19:42

Copilot started reviewing on behalf of JosunLP March 13, 2026 19:52 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/component/component.ts Show resolved Hide resolved

src/component/component.ts Outdated Show resolved Hide resolved

tests/component.test.ts Show resolved Hide resolved

Copilot started work on behalf of JosunLP March 13, 2026 20:00 View session

fix: handle reconnect lifecycle and signal effect errors

7b29f98

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot finished work on behalf of JosunLP March 13, 2026 20:05

JosunLP requested a review from Copilot March 13, 2026 20:55

Copilot started reviewing on behalf of JosunLP March 13, 2026 20:56 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/component/types.ts Outdated Show resolved Hide resolved

src/component/component.ts Outdated Show resolved Hide resolved

Copilot started work on behalf of JosunLP March 13, 2026 21:02 View session

fix: preserve reconnect signal wiring after hook errors

3fe00bc

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot finished work on behalf of JosunLP March 13, 2026 21:06

JosunLP requested a review from Copilot March 13, 2026 21:06

Copilot started reviewing on behalf of JosunLP March 13, 2026 21:07 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/component/component.ts Show resolved Hide resolved

Copilot started work on behalf of JosunLP March 13, 2026 21:19 View session

fix: skip beforeUpdate for signal rerenders

b783a30

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot finished work on behalf of JosunLP March 13, 2026 21:23

JosunLP requested a review from Copilot March 13, 2026 21:28

Copilot started reviewing on behalf of JosunLP March 13, 2026 21:29 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

JosunLP merged commit 99a9aa1 into development Mar 13, 2026
14 checks passed

JosunLP deleted the copilot/fr-6-signal-integration-component branch March 13, 2026 21:34

Uh oh!

Conversation

Copilot AI commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

JosunLP commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

JosunLP commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JosunLP commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

JosunLP commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

JosunLP commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 13, 2026 •

edited

Loading