Add typed state generics to component definitions by Copilot · Pull Request #56 · bQuery/bQuery

Copilot · 2026-03-13T11:15:03Z

ComponentDefinition already preserved prop types, but component state was still widened to Record<string, unknown>. This change threads an explicit state generic through the component API so render context and state helpers retain the declared state shape.

API typing
- Add TState to ComponentDefinition
- Add TState to ComponentRenderContext
- Thread TState through component() and defineComponent()
Typed state access
- Preserve state shape in render({ state })
- Constrain setState() and the keyed getState() overload to keyof TState so typed state helper usage stays aligned with the declared component state
- Expose typed defineComponent() instances/classes so state helpers remain visible to TypeScript consumers
Compatibility and lifecycle typing
- Preserve the untyped fallback when TState is not explicitly provided, so existing components can still use string-keyed state without inference changing behavior
- Keep backwards compatibility for untyped components via the legacy getState<T>(key: string): T cast-style overload
- Implement the string-key fallback through a record view internally so explicit TState typing and the legacy overload can coexist without type errors
- Keep lifecycle hooks on typed-this signatures while documenting that arrow hooks remain supported for callbacks that do not rely on component instance APIs via this
Coverage
- Add a focused component test that asserts typed state is preserved in both ComponentDefinition<Props, State> and ComponentRenderContext<Props, State>
- Add regression coverage for the untyped fallback path when TState is omitted, including the legacy getState<T>() compatibility path
- Enforce the component type-assertion tests in CI with a dedicated test:types step and focused test tsconfig so the new expectType / @ts-expect-error assertions are actually validated

type Props = { label: string };
type State = { count: number; ready: boolean };

component<Props, State>('counter-card', {
  props: {
    label: { type: String, required: true },
  },
  state: {
    count: 0,
    ready: false,
  },
  render({ props, state }) {
    state.count; // number
    state.ready; // boolean

    return html`<div>${props.label}: ${state.count}</div>`;
  },
});

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot

Pull request overview

This PR improves the component module’s TypeScript API by threading an explicit TState generic through component definitions and render contexts so component state no longer widens to Record<string, unknown>.

Changes:

Add TState generics to ComponentDefinition and ComponentRenderContext.
Thread TState through defineComponent() and component(), and type getState/setState against keyof TState.
Add a test asserting typed state is preserved for both ComponentDefinition<Props, State> and ComponentRenderContext<Props, State>.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
`src/component/types.ts`	Adds `TState` to component definition and render context typings.
`src/component/component.ts`	Threads `TState` through factory functions and types `getState`/`setState` accordingly.
`tests/component.test.ts`	Adds a type-focused test to validate state generic preservation.

src/component/types.ts

src/component/component.ts

JosunLP · 2026-03-13T12:08:07Z

@copilot apply changes based on the comments in this thread

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

tests/component.test.ts

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot · 2026-03-13T12:17:34Z

@copilot apply changes based on the comments in this thread

Applied the review-thread fixes in d9eecb8 and polished the final test adjustment in 8aa55fc. The follow-up now requires an initial state object for explicit TState, exposes typed defineComponent() state helpers/lifecycle this, updates the JSDoc examples, and passes lint, typecheck, build, tests, and CodeQL.

Copilot

Pull request overview

Threads a TState generic through the component type system so component render contexts, lifecycle hooks, and state helpers can preserve a declared state shape instead of widening to Record<string, unknown>.

Changes:

Add TState-aware component types (ComponentRenderContext, ComponentDefinition) and state helper typing (getState/setState) via ComponentStateShape.
Update defineComponent() and component() to accept and propagate TState (including typed this in lifecycle hooks).
Add type-focused tests ensuring state generics are preserved and state helpers are key/value constrained.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`src/component/types.ts`	Introduces `ComponentStateShape`/`ComponentElement`/`ComponentClass` and threads `TState` through `ComponentDefinition` + `ComponentRenderContext`.
`src/component/component.ts`	Updates `defineComponent()`/`component()` generics and strongly types internal state + `getState`/`setState`.
`tests/component.test.ts`	Adds type-level assertions (`@ts-expect-error`, `expectType`) validating typed state propagation and helper constraints.

src/component/component.ts

src/component/types.ts

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com>

src/component/component.ts

JosunLP · 2026-03-13T12:27:25Z

@copilot einige pipelines schlagen fehl

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot · 2026-03-13T14:39:43Z

@copilot apply changes based on the comments in this thread

Erledigt in 94b19c5. Ich habe die Rückwärtskompatibilität für getState wiederhergestellt: Neben den neuen typed-key Overloads unterstützt die API jetzt wieder getState<T>(key: string): T, sodass ungetypte Fallback-Komponenten bestehende Cast-Aufrufe behalten. Dazu gibt es fokussierte Typ-Assertions im Unset-State-Pfad; bun run test:types, die Component-Tests sowie lint/build/test laufen lokal erfolgreich, und CodeQL ist sauber. Keine UI-Änderung, daher kein Screenshot.

Copilot

Pull request overview

This PR extends the bquery/component API surface to support typed component state via a TState generic, and adds a dedicated CI type-check step to ensure type-level assertions in component tests are validated.

Changes:

Thread TState through ComponentDefinition, ComponentRenderContext, defineComponent(), and component() to preserve declared state shapes.
Add typed getState() / setState() overloads and update lifecycle hook typing to expose state helpers via this.
Add test:types (tsc against a focused test tsconfig) and corresponding CI step to enforce @ts-expect-error/expectType assertions.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`src/component/types.ts`	Adds `TState` generics and typed state shapes + hook/element helper types.
`src/component/component.ts`	Implements typed state plumbing in the runtime component class + overloads for `defineComponent`/`component`.
`tests/component.test.ts`	Adds type-assertion coverage for typed/untyped state paths; tightens prop validator type guards.
`tests/setup.ts`	Adjusts `getComputedStyle` global wiring for tests.
`tsconfig.component-test.json`	Introduces a dedicated tsconfig for type-checking component tests.
`package.json`	Adds `test:types` script to run the focused type-check.
`.github/workflows/test.yml`	Runs `test:types` in CI before runtime tests.

src/component/component.ts

JosunLP · 2026-03-13T14:47:30Z

@copilot apply changes based on the comments in this thread

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot · 2026-03-13T14:52:07Z

@copilot apply changes based on the comments in this thread

Erledigt in d1aa335. Die getState-Overloads bleiben unverändert, aber die Implementierung liest den String-Key-Fallback jetzt über eine Record<string, unknown>-Sicht auf this.state, sodass konkrete TState-Typen nicht mehr mit dem Legacy-Overload kollidieren. Ich habe den vorherigen fehlgeschlagenen Type-check tests-Run per Actions geprüft; lokal laufen bun run test:types, bun run lint:types, die Component-Tests sowie der vollständige lint/build/test-Durchlauf wieder sauber, und CodeQL ist ohne Befunde. Keine UI-Änderung, daher kein Screenshot.

Copilot

Pull request overview

Threads an explicit TState generic through the component API so component definitions, render contexts, and state helpers retain the declared state shape, and adds CI type-checking to enforce the new type assertions.

Changes:

Add TState to ComponentDefinition / ComponentRenderContext and introduce supporting types (ComponentStateShape, ComponentElement, ComponentClass).
Update defineComponent() / component() to support typed state helpers while preserving the untyped fallback + legacy getState<T>(key: string) overload.
Add component typing assertions + introduce a dedicated test:types CI step with a focused tsconfig.component-test.json.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tsconfig.component-test.json	Adds a focused TS config to type-check component typing assertions in tests.
tests/setup.ts	Adjusts the `getComputedStyle` global wiring for the test environment.
tests/component.test.ts	Adds typed-state type assertions and extends validator checks in prop validation tests.
src/component/types.ts	Introduces `TState` generics and new public component typing surface.
src/component/component.ts	Threads `TState` through component creation, adds typed `getState`/`setState` overloads, and overloads `defineComponent`/`component`.
package.json	Adds `test:types` script to run the focused TS type-check.
.github/workflows/test.yml	Runs `bun run test:types` in CI before runtime tests.

src/component/types.ts

src/component/component.ts

JosunLP · 2026-03-13T15:08:03Z

@copilot apply changes based on the comments in this thread

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot · 2026-03-13T15:12:23Z

@copilot apply changes based on the comments in this thread

Erledigt in 6ab5949. Die Lifecycle-Hook-Typen unterstützen jetzt wieder sowohl method-style Hooks mit typisiertem this als auch Arrow-Callbacks ohne this, und der getState-Block ist sauber an die umgebenden Methoden angepasst. Lokal laufen bun run test:types, bun run lint:types, die Component-Tests sowie der vollständige lint/build/test-Durchlauf wieder sauber; CodeQL ist ebenfalls ohne Befunde. Keine UI-Änderung, daher kein Screenshot.

Copilot

Pull request overview

This PR enhances the component module’s TypeScript API by threading a TState generic through component definitions and render contexts so state helpers and render({ state }) retain the declared state shape, while preserving an untyped fallback for backward compatibility. It also adds a dedicated CI type-check step to ensure type-assertion tests are actually validated.

Changes:

Add TState generics to ComponentDefinition and ComponentRenderContext, plus supporting state/element/class helper types.
Update defineComponent() / component() to carry typed state through to lifecycle this helpers and render context.
Add compile-time typing tests (with @ts-expect-error assertions) and enforce them via a new test:types CI step.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tsconfig.component-test.json	New focused TS config for type-checking component typing assertions.
tests/setup.ts	Adjusts `getComputedStyle` global wiring to a typed wrapper.
tests/component.test.ts	Adds typed-state type assertions and updates validators to be type-safe at runtime.
src/component/types.ts	Introduces `TState` generics and typed lifecycle hook `this` via overloaded call signatures.
src/component/component.ts	Threads typed state through `defineComponent`/`component`, adds overloads, and types state helpers.
package.json	Adds `test:types` script for CI type-checking.
.github/workflows/test.yml	Runs `bun run test:types` before runtime tests.

src/component/types.ts

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com>

Copilot

Pull request overview

This PR extends the component/defineComponent Web Components helper to support an explicit typed state generic (TState) so component render context, lifecycle hooks, and state helpers preserve the declared state shape instead of widening to Record<string, unknown>.

Changes:

Add TState plumbing across ComponentDefinition, ComponentRenderContext, lifecycle hook this typing, and defineComponent() / component() overloads.
Introduce typed getState/setState signatures while preserving the legacy cast-style getState<TResult>(key: string) overload for backward compatibility.
Add type-level assertions in component tests and enforce them in CI via a dedicated test:types TypeScript step.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`src/component/types.ts`	Adds `TState` generics, typed render context, typed lifecycle hook `this`, and state helper typings with compatibility overloads.
`src/component/component.ts`	Threads `TState` through `defineComponent()` / `component()` and updates internal state helper method signatures.
`tests/component.test.ts`	Adds runtime + type-level tests asserting typed-state behavior and untyped fallback behavior.
`tsconfig.component-test.json`	Adds a focused tsconfig to type-check `src` plus component tests with type assertions.
`.github/workflows/test.yml`	Runs the new type-check step in CI before runtime tests.
`package.json`	Adds the `test:types` script used by CI.
`tests/setup.ts`	Adjusts the `getComputedStyle` global wiring used by CSS-related tests.

* Add `bool()` support for boolean attributes in component templates (#55) Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Add typed state generics to component definitions (#56) Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Pass attribute change metadata to component `updated()` hooks (#58) Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Add per-component sanitizer overrides for component render output (#57) * Initial plan * feat: add per-component sanitizer options Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: clarify component sanitizer baseline Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: warn about sensitive component sanitizer opts Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * test: cover sanitizer allowTags overrides Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * perf: precompute component sanitizer allowlists Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Pass previous props into component `beforeUpdate` (#59) * Initial plan * Add previous props to beforeUpdate hook Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Refine beforeUpdate old props implementation Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Fix beforeUpdate typing regressions Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Add explicit signal subscriptions to `component()` renders (#60) * Initial plan * feat: add component signal subscriptions Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * chore: document signal subscription tracking Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: address signal integration review feedback Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: tighten component signal typing Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: resolve eslint failure in component signal test Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: handle reconnect lifecycle and signal effect errors Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: preserve reconnect signal wiring after hook errors Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: skip beforeUpdate for signal rerenders Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Add trusted sanitized fragments for `safeHtml` composition (#61) * Initial plan * feat: add trusted safeHtml fragment support Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * chore: finalize trusted safeHtml support Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: address trusted safeHtml review feedback Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: fix second trusted safeHtml review follow-up Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * refactor: split trusted html helpers from sanitizer Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * refactor: tighten trusted html branding Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: tighten trusted html internals Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> * Reuse component shadow-root style nodes across re-renders (#62) * Initial plan * fix: reuse component style element on rerender Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * chore: finalize component style reuse fix Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * test: tighten style reuse regression assertions Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Add `@bquery/bquery/storybook` template helpers for Storybook stories (#63) * Initial plan * feat: add storybook template helper Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs: clarify storybook when fallback behavior Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: keep storybook helpers out of full bundle Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix: sanitize storybook helper output Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * test: tighten storybook helper security coverage Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * feat: enhance storyHtml with improved boolean attribute handling and sanitization tests * fix: update storyHtml example to reflect correct boolean attribute output * fix: defensive tag delimiter and parser comments per code review Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * chore: release version 1.6.0 - Update CHANGELOG.md for version 1.6.0 release notes including added features, changes, fixes, and security improvements. - Enhance README.md to document new boolean attribute helpers and Storybook integration. - Update bun.lock to reflect dependency upgrades for Storybook and happy-dom. - Modify definition.md to include new Storybook helpers and component state management features. - Revise components.md to demonstrate new boolean attribute handling and typed state in components. - Update getting-started.md with Storybook authoring examples and improved module descriptions. - Enhance security.md to clarify sanitization practices and introduce trusted fragment handling. - Revise index.md to highlight new Storybook helpers in the feature list. - Update llms.txt to reflect the new version 1.6.0. - Bump version in package.json to 1.6.0 and update devDependencies for Storybook. * Address review feedback for test setup, test type coverage, and component state keys (#65) * Initial plan * Address review feedback for test typing and setup Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Finalize review feedback fixes Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Export component state key type Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Default component state key generic Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Tighten component/state update semantics and Storybook attribute sanitization (#66) * Initial plan * fix review follow-up for state updates and storybook sanitization Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix storybook attribute value scanning Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * fix storybook interpolation boundary parsing Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * docs align storybook attribute scan jsdoc Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de>

Initial plan

54c5ab5

Copilot AI assigned Copilot and JosunLP Mar 13, 2026

Copilot started work on behalf of JosunLP March 13, 2026 11:15 View session

Copilot AI and others added 2 commits March 13, 2026 11:18

Add typed state generic to component definitions

68183c5

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Align component state helpers with typed generics

4daea80

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add second generic parameter for typed state~~ Add typed state generics to component definitions Mar 13, 2026

Copilot AI requested a review from JosunLP March 13, 2026 11:22

Copilot finished work on behalf of JosunLP March 13, 2026 11:22

JosunLP marked this pull request as ready for review March 13, 2026 11:26

Copilot AI review requested due to automatic review settings March 13, 2026 11:26

github-actions bot added component Changes to the component module tests Chenges to the tests labels Mar 13, 2026

Copilot started reviewing on behalf of JosunLP March 13, 2026 11:27 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

Copilot started work on behalf of JosunLP March 13, 2026 12:08 View session

Address typed component state review comments

d9eecb8

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

github-advanced-security bot found potential problems Mar 13, 2026

View reviewed changes

tests/component.test.ts Fixed Show fixed Hide fixed

Polish typed component state follow-up tests

8aa55fc

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot finished work on behalf of JosunLP March 13, 2026 12:18

JosunLP requested a review from Copilot March 13, 2026 12:19

Copilot started reviewing on behalf of JosunLP March 13, 2026 12:19 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/component/component.ts Outdated Show resolved Hide resolved

src/component/types.ts Outdated Show resolved Hide resolved

JosunLP and others added 2 commits March 13, 2026 13:26

Potential fix for pull request finding

f99e66a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com>

Potential fix for pull request finding

2a0ded4

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com>

github-advanced-security bot found potential problems Mar 13, 2026

View reviewed changes

src/component/component.ts Fixed Show fixed Hide fixed

Copilot started work on behalf of JosunLP March 13, 2026 12:27 View session

Preserve getState cast overload compatibility

94b19c5

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot finished work on behalf of JosunLP March 13, 2026 14:40

JosunLP requested a review from Copilot March 13, 2026 14:40

Copilot started reviewing on behalf of JosunLP March 13, 2026 14:41 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/component/component.ts Outdated Show resolved Hide resolved

Copilot started work on behalf of JosunLP March 13, 2026 14:47 View session

Fix getState implementation typing

d1aa335

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot finished work on behalf of JosunLP March 13, 2026 14:53

JosunLP requested a review from Copilot March 13, 2026 15:01

Copilot started reviewing on behalf of JosunLP March 13, 2026 15:02 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/component/types.ts Outdated Show resolved Hide resolved

src/component/component.ts Outdated Show resolved Hide resolved

Copilot started work on behalf of JosunLP March 13, 2026 15:08 View session

Restore arrow lifecycle hook typings

6ab5949

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>

Copilot finished work on behalf of JosunLP March 13, 2026 15:13

JosunLP requested a review from Copilot March 13, 2026 15:13

Copilot started reviewing on behalf of JosunLP March 13, 2026 15:13 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/component/types.ts Outdated Show resolved Hide resolved

Potential fix for pull request finding

1595879

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com>

JosunLP requested a review from Copilot March 13, 2026 15:21

Copilot started reviewing on behalf of JosunLP March 13, 2026 15:22 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

JosunLP merged commit 0d1a37a into development Mar 13, 2026
14 checks passed

JosunLP deleted the copilot/add-typed-state-generic branch March 13, 2026 15:28

Uh oh!

Conversation

Copilot AI commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JosunLP commented Mar 13, 2026

Uh oh!

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JosunLP commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

JosunLP commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

JosunLP commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 13, 2026 •

edited

Loading