Allow automatic extraction of lid from List-Id header#241
Open
sbp wants to merge 1 commit into
Open
Conversation
Contributor
|
However fixing the bug will effectively change the generate ids. |
Contributor
Author
|
This doesn't fix the bug. The bug is still present, unless the new |
sebbASF
requested changes
Jun 15, 2022
sebbASF
left a comment
Contributor
There was a problem hiding this comment.
Also I think there needs to be a test to show that the generated id is the same whether automatic mode is used or the lid is provided
| elif len(argv) == 3: # add lid | ||
| lid: Optional[bytes] = argv[2].encode("utf-8") | ||
| automatic: bool = False | ||
| if lid == b"-": |
Contributor
There was a problem hiding this comment.
This special value needs documenting
| head_canon: bool = False, | ||
| body_canon: bool = False, | ||
| lid: Optional[bytes] = None, | ||
| automatic: bool = False, |
| data: bytes, lid: Optional[bytes] = None | ||
| data: bytes, | ||
| lid: Optional[bytes] = None, | ||
| automatic: bool = False, |
|
|
||
| def dkim_id(data: bytes, lid: Optional[bytes] = None) -> str: | ||
| def dkim_id( | ||
| data: bytes, lid: Optional[bytes] = None, automatic: bool = False |
Contributor
There was a problem hiding this comment.
automatic arg needs documenting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR means that you can run
python3 dkim_id.py example.eml -and the lid is automatically extracted from theList-Idheader, if present, without incurring the bug in #113.