Skip to content

Add code reuse FAQ to NG Module Guide#17129

Closed
rjcorwin wants to merge 2 commits intoangular:masterfrom
rjcorwin:master
Closed

Add code reuse FAQ to NG Module Guide#17129
rjcorwin wants to merge 2 commits intoangular:masterfrom
rjcorwin:master

Conversation

@rjcorwin
Copy link
Copy Markdown

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe: Purely just documentation.

What is the current behavior? (You can also link to an open issue here)
Folks expect that there is standard tooling for sharing Angular Modules.

What is the new behavior?
There is not standard tooling for sharing Angular Modules.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Related issue: angular/angular-cli#6510

Which is a continuation of this heated issue: angular/angular-cli#1692

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@rjcorwin
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@rjcorwin
Copy link
Copy Markdown
Author

If PR #16486 is merged, then this PR will not be necessary.


## How do I reuse Angular Modules in other projects?

Currently there is no official way to package Angular Modules for resuse. Follow [this issue](https://github.com/angular/angular-cli/issues/6510) for updates.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-use

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Jun 1, 2017

@rjsteinert I'm closing this because we plan to improve the docs (and the CI is red and there are 2 commits)

Thanks for your feedback

@vicb vicb closed this Jun 1, 2017
@rjcorwin
Copy link
Copy Markdown
Author

rjcorwin commented Jun 1, 2017

Got it. I see the CI feedback now...

INVALID COMMIT MSG: "Merge pull request #1 from angular/master"
 => ERROR: The commit message does not match the format of "<type>(<scope>): <subject> OR revert: type(<scope>): <subject>"
Please fix the failing commit messages before continuing...
Commit message guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

And I'll rebase master in the future so there aren't merge commits.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants