WIP - AIO: Third party library guide by filipesilva · Pull Request #16486 · angular/angular

filipesilva · 2017-05-02T18:44:43Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe: AIO third party lib guide

What is the current behavior? (You can also link to an open issue here)
N/A

What is the new behavior?
A guide for third party library development is added. This PR is a port from angular/angular.io#3411.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
For now the quickstart lib seed is hosted at https://github.com/filipesilva/angular-quickstart-lib. It should be hosted under the angular org upon release.

/cc @wardbell @alxhub

mary-poppins · 2017-05-02T19:02:01Z

The angular.io preview for 1c9e4ce4cd170640def0191d93a57c88a22bf7aa is available here.

gkalpak

That will be really helpful for library authors 👍

gkalpak · 2017-05-02T19:36:47Z

aio/content/guide/third-party-lib.md

Inconsistent capitalization AOT (here) vs AOT (above).

gkalpak · 2017-05-02T19:45:16Z

aio/content/guide/third-party-lib.md

I've noticed several variations throughout the text for terms like AOT anf JIT (e.g. "AoT" vs "AOT", "Ahead of Time" vs "Ahead-of-time" etc). I think we should be consistent.

gkalpak · 2017-05-02T19:45:47Z

aio/content/guide/third-party-lib.md

bundle --> code (?)

gkalpak · 2017-05-02T19:49:44Z

aio/content/guide/third-party-lib.md

were followed copied onto the same file file --> ?

gkalpak · 2017-05-02T19:53:03Z

aio/content/guide/third-party-lib.md

The link is invalid. Is the project supposed to be created later?

Correct, for now it is in https://github.com/filipesilva/angular-quickstart-lib. When this guide is approved we can move the codebase under the Angular org.

gkalpak · 2017-05-02T20:19:23Z

aio/content/guide/third-party-lib.md

Wrong link. It should be guide/third-party-lib#appendix-dependency-management.

gkalpak · 2017-05-02T20:23:10Z

aio/content/guide/third-party-lib.md

? --> . (?)

gkalpak · 2017-05-02T20:24:32Z

aio/content/guide/third-party-lib.md

app --> library

gkalpak · 2017-05-02T20:24:59Z

aio/content/guide/third-party-lib.md

Remove this line.

gkalpak · 2017-05-02T20:27:37Z

aio/content/guide/third-party-lib.md

peer Dependency --> peer dependency (?)

FriOne · 2017-05-10T13:20:21Z

@filipesilva It would be nice to have a seed on github for this instead of text(or both). Thanks, It should help me to solve a problem.

filipesilva · 2017-05-10T14:04:19Z

@FriOne the seed is temporarily at https://github.com/filipesilva/angular-quickstart-lib

filipesilva · 2017-05-10T15:21:39Z

Thank you for the review @gkalpak, lots of improvements there.

danwulff · 2017-05-25T21:42:58Z

I'm looking forward to this being merged and the quickstart-lib codebase being added to @angular.

nathanosdev · 2017-06-03T13:13:33Z

aio/content/guide/third-party-lib.md

Add a comma after 'publishing', otherwise the sentence can be confusing the first time it is read.

nathanosdev · 2017-06-03T13:16:28Z

aio/content/guide/third-party-lib.md

All mentions of 'meta data' here are inconsistent with references to 'metadata' elsewhere in the document. It should be 'metadata' everywhere.

austince · 2017-07-20T15:38:23Z

aio/content/guide/third-party-lib.md

Typo: are correctly build: -> are correctly built:

johnpapa · 2017-10-09T19:18:55Z

What is the status on this? Would love to have official Angular team guidance on creating these library apps.

IgorMinar · 2018-02-06T23:45:13Z

@filipesilva should we try to resurrect this guide and reuse it for the docs we'll need for the upcoming library support in CLI? or should we close this PR?

cc: @jenniferfell

filipesilva · 2018-02-08T08:45:23Z

@IgorMinar I think at this point too much has changed. The examples will not be applicable to the new source, and neither will be the explanations about internals.

I think it should be closed but used as inspiration for a new one. The structure and the peripheral explanations still apply.

brandonroberts · 2018-08-03T14:47:13Z

Closing this one for now.

angular-automatic-lock-bot · 2019-09-13T21:53:00Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label May 2, 2017

gkalpak reviewed May 2, 2017

View reviewed changes

wardbell added comp: aio and removed cla: yes labels May 4, 2017

This was referenced May 5, 2017

AOT error when referencing components from another project angular/angular-cli#6059

Closed

"Please add a @NgModule annotation." error with AOT, full path vs short package.json main angular/angular-cli#6239

Closed

googlebot added the cla: yes label May 10, 2017

This was referenced May 11, 2017

Library with Typescript files fails to compile in AOT angular/angular-cli#6228

Closed

[Feature] Create boilerplate for library angular/angular-cli#1692

Closed

tomwanzek mentioned this pull request May 16, 2017

Fails when use systemjs.config.js tomwanzek/d3-ng2-service#27

Closed

ajcrites mentioned this pull request May 18, 2017

Built module distribution cannot be imported to other modules angular/angular-cli#6378

Closed

robwormald mentioned this pull request May 31, 2017

[RFC] Library Support and Boilerplate Comment Thread angular/angular-cli#6510

Closed

rjcorwin mentioned this pull request May 31, 2017

Add code reuse FAQ to NG Module Guide #17129

Closed

3 tasks

nathanosdev reviewed Jun 3, 2017

View reviewed changes

wardbell added area: packaging Issues related to Angular's creation of npm packages area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime and removed comp: aio labels Jun 21, 2017

austince reviewed Jul 20, 2017

View reviewed changes

aio/content/guide/third-party-lib.md Outdated

Copy link
Copy Markdown

austince Jul 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: are correctly build: -> are correctly built:

franzbecker mentioned this pull request Jul 25, 2017

import seed project test-editor/deprecated-web-workspace-navigator#1

Merged

filipesilva added 3 commits July 26, 2017 12:54

add nav and dummy file

71f652b

add base jade

4c42ae8

add auto converted

0d0f1cd

filipesilva added 4 commits July 26, 2017 12:54

fix tables and filetree

d09b402

add title/intro

f2d632f

review content

c5d11f9

incorporate @gkalpak's feedback

97c6e83

mhevery force-pushed the new-cb-third-party-lib branch from fe1d5c9 to 97c6e83 Compare July 26, 2017 19:54

axtho mentioned this pull request Aug 11, 2017

update the link parts for angular-cli and update to ngrx v4 benorama/ngrx-demo-apps#13

Closed

ebtc mentioned this pull request Aug 15, 2017

core(bug): adapt to latest cli digitaldeacon/memberhive#149

Closed

lazarljubenovic mentioned this pull request Sep 16, 2017

Use the Angular Package Format sebholstein/angular-google-maps#1157

Closed

jenniferfell added the state: community Someone from the Angular community is working on this issue or submitted this PR label Jul 23, 2018

brandonroberts closed this Aug 3, 2018

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Conversation

filipesilva commented May 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mary-poppins commented May 2, 2017

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FriOne commented May 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filipesilva commented May 10, 2017

Uh oh!

filipesilva commented May 10, 2017

Uh oh!

danwulff commented May 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnpapa commented Oct 9, 2017

Uh oh!

IgorMinar commented Feb 6, 2018

Uh oh!

filipesilva commented Feb 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brandonroberts commented Aug 3, 2018

Uh oh!

angular-automatic-lock-bot bot commented Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

filipesilva commented May 2, 2017 •

edited

Loading

FriOne commented May 10, 2017 •

edited

Loading

filipesilva commented Feb 8, 2018 •

edited

Loading