fix jetbrains recents parsing for 2019.3 eap#70
fix jetbrains recents parsing for 2019.3 eap#70ManuelSchneid3r merged 2 commits intoalbertlauncher:devfrom iyzana:fix-jetbrains-recents-parsing
Conversation
|
The EAP version started generating xml that looks like this: ...
<RecentProjectMetaInfo projectWorkspaceId="...">
<option name="binFolder" value="$APPLICATION_HOME_DIR$/bin" />
<option name="build" value="IU-193.3519.25" />
<option name="buildTimestamp" value="1568822400642" />
<option name="eap" value="true" />
<frame x="17" y="17" width="933" height="1046" extendedState="6" />
<option name="productionCode" value="IU" />
<option name="projectOpenTimestamp" value="1569415744426" />
</RecentProjectMetaInfo>
...and the |
|
That explains it, thanks! |
|
(In case you are wondering why nothing is happening here, I don't have any merge rights, so we have to wait for @ManuelSchneid3r to merge this) |
|
i figured, i've had #64 open for ~7 months now |
|
@iyzana thanks for this, before it gets merged, it may be safer to just check for existence of the attribute, rather than the tag name (in case JB decides to use - if o.tag == 'option' and o.attrib["name"] == 'projectOpenTimestamp':
+ if 'name' in o.attrib and o.attrib["name"] == 'projectOpenTimestamp':or a combination of both |
|
@Sharsie yeah, probably a good idea. done |
felipeassoline
left a comment
There was a problem hiding this comment.
It works here!!! Thanks for this change :)
|
Short notice for everyone who is interested: I made a few more fixes to the plugin and am now hosting the plugin here: https://github.com/mqus/jetbrains-albert-plugin |
686718e to
a1ab7f4
Compare
please upstream. i you like owning your own repo you could also make a submodule |
No description provided.