This repository was archived by the owner on Oct 15, 2025. It is now read-only.
improve gnu units output parsing#64
Closed
iyzana wants to merge 3 commits intoalbertlauncher:devfrom
iyzana:improve-units-output
Closed
improve gnu units output parsing#64iyzana wants to merge 3 commits intoalbertlauncher:devfrom iyzana:improve-units-output
iyzana wants to merge 3 commits intoalbertlauncher:devfrom
iyzana:improve-units-output
Conversation
iyzana
commented
Apr 19, 2019
686718e to
a1ab7f4
Compare
Member
|
Unfortunately I let you all wait pretty long. Now I have the problem that I don't know which PR's are valid at all. Therefore I will close all PR's for tentatively. If you want me to reopen the PR let me know. Also it would be nice if you could resolve potential conflicts due to changes in the repo. Sorry for the inconveniences, but I am working on it for a week now. I'm in a hurry. Note that this is a copy paste message. 😉 |
Contributor
Author
|
No problem.
Yep, this PR is still valid. |
Member
|
Wtf
Never had this. What is this? |
Contributor
Author
|
That's new for me as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
units 500seconds timeis currently giving output like this0;0;0;8;20which is not very human friendlythis PR changes the output to
8 min + 20 seci believe the other outputs are unchanged:
units 5min=>300 sunits 1foot cm=>30.48also, giving negative inputs is now supported, as units interpreted them as flags before