[release/v7.6] Update the WCF packages to the latest version that is compatible with v4.10.3 #26503
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR backports WCF package updates from master (#26406) to the v7.6 release branch. The changes update WCF packages from version 4.10.3 to 10.0.0-rc.2.final to achieve .NET 10 compatibility. The update removes three deprecated package references (System.Private.ServiceModel, System.ServiceModel.Duplex, System.ServiceModel.Security) which are now provided as facade assemblies in the newer packages. Additionally, the BOM manifest is updated to reflect the new assembly structure with granular System.ServiceModel.* resource DLLs replacing the monolithic System.Private.ServiceModel resources. The PR also enhances the packaging module to support GitHub Actions artifact uploads and creates placeholder files for new SBOM manifest requirements.
- Upgrades WCF packages to 10.0.0-rc.2.final for .NET 10 compatibility
- Updates BOM manifest to reflect new WCF assembly structure
- Adds GitHub Actions support for log file capture
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj | Updates WCF package references from 4.10.3 to 10.0.0-rc.2.final, removes deprecated packages |
| src/System.Management.Automation/System.Management.Automation.csproj | Cleans up commented-out package references |
| tools/packaging/packaging.psm1 | Adds creation of bsi.json and manifest.cat files, implements GitHub Actions log capture |
| tools/packaging/boms/windows.json | Removes System.Private.ServiceModel resource DLLs, adds granular System.ServiceModel.* resource DLLs for all locales |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } elseif ($env:GITHUB_WORKFLOW -and $env:SYSTEM_ARTIFACTSDIRECTORY) { | ||
| ## In GitHub Actions | ||
| $destinationPath = $env:SYSTEM_ARTIFACTSDIRECTORY |
There was a problem hiding this comment.
The environment variable check uses $env:SYSTEM_ARTIFACTSDIRECTORY which is an Azure DevOps variable, not a GitHub Actions variable. Based on existing patterns in the codebase (build.psm1:1779, ci.psm1:465), GitHub Actions should check for $env:RUNNER_WORKSPACE instead. This will cause the GitHub Actions path to always evaluate to false since SYSTEM_ARTIFACTSDIRECTORY won't be set in GitHub Actions.
| } elseif ($env:GITHUB_WORKFLOW -and $env:SYSTEM_ARTIFACTSDIRECTORY) { | |
| ## In GitHub Actions | |
| $destinationPath = $env:SYSTEM_ARTIFACTSDIRECTORY | |
| } elseif ($env:GITHUB_WORKFLOW -and $env:RUNNER_WORKSPACE) { | |
| ## In GitHub Actions | |
| $destinationPath = $env:RUNNER_WORKSPACE |
| { | ||
| "Pattern": "Modules\\Microsoft.PowerShell.PSResourceGet\\Microsoft.PowerShell.PSResourceGet.pdb", |
There was a problem hiding this comment.
The removal of Modules/ThreadJob/*.psd1, Modules\\ThreadJob\\.signature.p7s, and Modules\\ThreadJob\\ThreadJob.psm1 entries appears unrelated to the WCF package updates described in the PR. These removals should either be explained in the PR description or handled in a separate change to maintain clear change tracking.
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
932aea6
into
PowerShell:release/v7.6
Backport of #26406 to release/v7.6
Triggered by @TravisEz13 on behalf of @daxian-dbw
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Updates WCF packages from 4.10.3 to 10.0.0-rc.2.final, which is compatible with .NET 10. Fixes #19238 by removing deprecated packages (System.Private.ServiceModel, System.ServiceModel.Duplex, System.ServiceModel.Security) and updating to newer compatible versions. Also updates BOM manifest for new assembly structure and improves log file capture for GitHub Actions.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Original PR verified that ActiveDirectory module can be correctly imported with the updated WCF packages. Changes to packaging.psm1 improve GitHub Actions compatibility without affecting existing functionality.
Risk
REQUIRED: Check exactly one box.
Medium risk as it updates core dependency packages, but these are build/packaging dependencies. The 10.0.0-rc.2.final WCF packages are backward compatible, shipping facade assemblies for removed packages. Changes were validated in master and the ActiveDirectory module functionality was verified.