Skip to content

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Nov 8, 2025

PR Summary

Fix #19238

  1. Remove the PackageReference items that were commented out.
  2. Update the WCF packages to use the latest compatible version 10.0.0-rc.2.final.

The 10.0.0-rc.2.final version ServiceModel packages are backward compatible:

  • The packages System.ServiceModel.Duplex, System.ServiceModel.Security, and System.Private.ServiceModel are discontinued.

  • The package System.ServiceModel.Primitives ships 3 facade assemblies

    • System.ServiceModel.dll
    • System.ServiceModel.Duplex.dll
    • System.ServiceModel.Security.dll
  • The package System.Private.ServiceModel is no longer needed, as every package now carries its own implementation.

I have verified that the ActiveDirectory module can be correctly imported with in PowerShell built with the 10.0.0-rc.2.final WCF packages.


Before this change, the *ServiceModel* assemblies carried by PowerShell are:

System.Private.ServiceModel
System.ServiceModel
System.ServiceModel.Duplex
System.ServiceModel.Http
System.ServiceModel.NetTcp
System.ServiceModel.Primitives
System.ServiceModel.Security
System.ServiceModel.Syndication
System.ServiceModel.Web

After this change, the *ServiceModel* assemblies carried by PowerShell are:

System.ServiceModel
System.ServiceModel.Duplex
System.ServiceModel.Http
System.ServiceModel.NetFramingBase
System.ServiceModel.NetTcp
System.ServiceModel.Primitives
System.ServiceModel.Security
System.ServiceModel.Syndication
System.ServiceModel.Web

The difference of Before vs. After is shown below. The System.Private.ServiceModel.dll is no longer needed with the latest version, and the System.ServiceModel.NetFramingBase.dll is a new dependency of the System.ServiceModel.NetTcp.dll.

PS> Compare-Object -ReferenceObject $before -DifferenceObject $after

InputObject                        SideIndicator
-----------                        -------------
System.ServiceModel.NetFramingBase =>
System.Private.ServiceModel        <=

Copilot AI review requested due to automatic review settings November 8, 2025 05:43
@daxian-dbw daxian-dbw requested review from a team and jshigetomi as code owners November 8, 2025 05:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes commented-out package references and updates System.ServiceModel packages to version 10.0.0-rc.2.final.

  • Removes commented-out package references that were causing NU1510 warnings in System.Management.Automation.csproj
  • Updates System.ServiceModel packages from v4.10.3 to v10.0.0-rc.2.final (major version upgrade)
  • Removes several System.ServiceModel packages (Duplex, Security, Private.ServiceModel) and associated comments about version pinning

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/System.Management.Automation/System.Management.Automation.csproj Cleans up commented-out package references for DiagnosticSource, IO.FileSystem.AccessControl, Security.AccessControl, and Text.Encoding.CodePages
src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj Updates System.ServiceModel packages from v4.10.3 to v10.0.0-rc.2.final and removes Duplex, Security, and Private.ServiceModel packages along with their explanatory comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@daxian-dbw daxian-dbw changed the title Wcf pkgs Update the WCF packages to the latest version that is compatible with v4.10.3 Nov 10, 2025
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 10, 2025
@daxian-dbw daxian-dbw merged commit e069c1d into PowerShell:master Nov 11, 2025
40 checks passed
@daxian-dbw daxian-dbw deleted the wcf_pkgs branch November 11, 2025 22:25
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Nov 20, 2025
SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.6.x-Migrated CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving System.ServiceModel.* packages to 6.0.0 and above will prevent the ActiveDirectory module from being loaded in PowerShell

2 participants