Various Enhancements#66
Conversation
reitermarkus
commented
May 6, 2019
- Update to Swift 5
- Switch to Carthage
- German Translation
- Switch to DDC.swift
- Refactoring
|
@the0neyouseek, I changed the |
There was a problem hiding this comment.
Should we have a more future proof approach and store this specific configuration in a file somewhere (Utils.swift for example) ? I'm thinking something like :
struct DisplayWithExceptions {
var name: String?
var vendorNumber: Int
var modelNumber: Int
var exceptions: [DisplayException]
}
enum DisplayException {
case longerDelay
case hideOsd
}
static let displaysToCheck: [DisplayWithExceptions] = [
DisplayWithExceptions.init(name: "LG Ultrawide",
vendorNumber: 7789,
modelNumber: 30460,
exceptions: [.hideOsd, .longerDelay])
]Then we would loop over this for any function that requires it
Edit: Other than this, amazing PR ! Thanks for your incredible work on this !
|
@the0neyouseek, ok, I added a whitelist now. |
|
I'll build and publish an updated version tonight |
|
@the0neyouseek, I made a release draft so you only have to build it. 😉 |
|
@reitermarkus Thanks for all your work ! If you have time, could you take a look through the open issues and close the ones that should now be fixed by this PR (or even #59). Have a nice day ! |