Skip to content

Project upgrade, stability improvements, new features (see description)#59

Merged
the0neyouseek merged 6 commits intoMonitorControl:masterfrom
JoniVR:pr/the0neyouseek
Feb 4, 2019
Merged

Project upgrade, stability improvements, new features (see description)#59
the0neyouseek merged 6 commits intoMonitorControl:masterfrom
JoniVR:pr/the0neyouseek

Conversation

@JoniVR
Copy link
Member

@JoniVR JoniVR commented Jan 11, 2019

Hi @the0neyouseek ,

As promised, my PR with enhancements and fixes for MonitorControl.

Here are the main changes

  • Code migration to Swift 4.2
  • Fixed the MonitorControl scheme which was gone for me
  • Updated the screenshots and readme
  • Added a feature that detects the default sound output device and only intercepts when an external display is set as default output, so Airpods, internal macbook volume and other non-monitor devices will be ignored (Listening for volume doesn't work with non monitor output #48, Audio source change #15)
  • Fixed app unresponsiveness and high CPU on launch (might be related to Mouse cursor stutters as soon as the app is launched #50, High CPU usage. #37, please do keep in mind that on initial launch there will still be a little unresponsiveness because the underlying framework - called ddcctl - attempts to read your volume settings 10 times)
  • Added a version and build number to the main preferences panel:
    menugeneral
  • Added a build script that increases the build number on each run. Version number still needs to be set manually.
  • refactored some parts of the code to make it a bit more readable.

Some things to note

  • I can't test multiple monitors as I only have a single external monitor.
  • Please test my changes and let me know if I broke something.
  • If you don't agree with something I did, or think there is a better solution, please let me know.
  • Please don't forget to increase the version number inside Xcode when you release, otherwise there will be confusion with which version people are using (for example when they open an issue).

Best regards
Joni

JoniVR and others added 6 commits January 11, 2019 17:52
…ctor

- fixed an issue where the default volume controls would be intercepted (and thus not work) when an external display was connected and the output set to a device that allows volume control by default.
- code cleanup / refactor
- added a version and build number to the general settings menu
- added a script to automatically increase the build number
- updated the build number to reflect the latest release
@the0neyouseek
Copy link
Member

Hi @JoniVR !

Thanks for the amazing PR 🎉 , can you allow changes from me so that I can make a few adjustments and merge it ?

@JoniVR
Copy link
Member Author

JoniVR commented Jan 13, 2019

Hi @the0neyouseek

This has been enabled from the start (if this is what you mean):
image

edit:
Are you experiencing issues pushing commits to it?

@JoniVR
Copy link
Member Author

JoniVR commented Jan 20, 2019

Hi @the0neyouseek
Any updates on this?

@the0neyouseek
Copy link
Member

@JoniVR Still haven't had time to take a look but will soon 🙏

@the0neyouseek the0neyouseek merged commit 830878e into MonitorControl:master Feb 4, 2019
@JoniVR JoniVR deleted the pr/the0neyouseek branch February 4, 2019 19:54
@the0neyouseek the0neyouseek mentioned this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants