Skip to content

refactor(wall): revert to e6006d6 layout + add contributor badge - #5

Merged
sakanni merged 1 commit into
mainfrom
feat/wall-revert-badge
Jun 8, 2026
Merged

sakanni merged 1 commit into
mainfrom
feat/wall-revert-badge

Conversation

@sakanni

@sakanni sakanni commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Reverts the wall rendering to the cleaner pre-stylise state (commit `e6006d6` on `feat/wall-of-honour`) which you preferred, with two small additions on top:

  1. Contributor count as a shields.io badge in place of the previous "N people have contributed" prose line:
    `Contributors`
    Empty state uses lightgrey color and shows 0.
  2. "Last updated YYYY-MM-DD" italicised at the bottom.

What this drops

All of the intermediate visual polish piled on across PRs #1-4:

  • `<div align="center">` wrapper
  • `
    ` separator
  • `` declarations
  • `valign="top"` on cells
  • Fixed `` and `CELL_WIDTH` constant
  • Name truncation + `NAME_MAX_LEN` constant
  • `@login` in title attribute (back to plain name)
  • Various column-count and avatar-size iterations

Constants back to:

  • `GRID_COLS = 7`
  • `AVATAR_SIZE = 100`

Heads up

This will likely still show a horizontal scrollbar on narrow viewports (the 7x100 table is ~700px wide, same as the original PR #1 layout). You confirmed knowing the trade-off.

Tests

  • 28/28 passing
  • New assertions cover badge URL presence and italic last-updated format

@sakanni
sakanni force-pushed the feat/wall-revert-badge branch from bb0c5ec to 4d18d3e Compare June 8, 2026 16:20
Reverts the rendering logic to the e6006d6 state (the post-denylist,
pre-stylise-bundle commit which the user preferred), then layers two
small additions on top:

- Replace the "N people have contributed" prose line with a shields.io
  contributors badge: ![Contributors](https://img.shields.io/badge/contributors-N-brightgreen)
  Empty state uses lightgrey color and shows 0.
- Italicise "Last updated YYYY-MM-DD" at the bottom

Drops all the intermediate visual polish (centered wrapper, hr separator,
colgroup, valign-top, fixed cell widths, NAME_MAX_LEN truncation,
@login title attribute, 12-column shrink, 6-column shrink). The wall is
back to plain 7-column x 100px-avatar layout.

Wall is 22 rows tall for 151 contributors. Will likely still produce a
horizontal scroll on narrow viewports (table is ~700px wide); user
explicitly chose this state knowing the trade-off.
@sakanni
sakanni merged commit af2a27a into main Jun 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant