feat: add Wall of Honour - #1
Merged
Merged
Conversation
Adds DENYLISTED_LOGINS frozenset and filter_denylist function applied after filter_bots in main(). Catches non-human accounts that don't have type=Bot or a [bot] login suffix: - BHoMBot: BHoM org automation bot - BuroHappold1: shared "Administrator" account Wall regenerated against real BHoM org: 153 -> 151 unique contributors.
Layout:
- Drop avatar size 100 -> 70; bump grid 7 -> 10 cols
- Fixed cell width (80px) + padded incomplete rows for uniform alignment
- valign="top" anchors avatars to top so wrapped names don't push them around
- cellpadding="4" cellspacing="0" for compact spacing
- Wrap heading/table/stats in <div align="center">
- Add hr separator above wall to space it from preceding README content
Content:
- Replace "## Wall of Honour" heading with prose intro:
"Contributors who have supported and advanced the BHoM."
- Replace "X people have contributed to BHoM" with footer stats:
"N contributors across M repositories. Last updated YYYY-MM-DD."
- Pluralization helper so 1/N both read correctly
Names:
- Truncate display names >15 chars with ellipsis
- Full name still available via title attr swapped to @login (GitHub alias)
- HTML-escape display in <sub> for special characters
Resilience:
- enrich_display_names catches HTTPError so deleted accounts (404 on
users/{login}) fall back to login instead of crashing the workflow
Tests:
- Anonymize fixtures: replace Thomas Edward Kingstone with mocklongname
- 35/35 passing
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files added
Test plan
Spec / Plan references