Merged
Conversation
|
Here is the summary of changes. You added 11 region tags.
This comment is generated by snippet-bot.
|
Contributor
|
Re: snippet-bot's comment I guess you're moving samples under I think the correct course of action is to 1) duplicate the sample, 2) update devsite, then 3) remove the old tags. |
b80cd52 to
58f2d2d
Compare
Contributor
Author
|
Thanks @tmatsuo for looking. Yes, I am trying to move these samples. I'll try your suggested process. |
docs: restore old view snippets remove relative imports docs: fix missing space in comment sort imports
fa645bf to
8240434
Compare
shollyman
approved these changes
Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These snippets are copied from snippets.py and refreshed
to include imports and client construction. Will follow up
with a PR to remove the redundant snippets once the docs
on cloud.google.com are updated.
I notice that the tests for these snippets have been skipped.
I believe that was due to a temporary rollout issue with
table update. If that actually is flakier than I thought, we
can more easily add retries or disable just updates in this
new structure.
python-bigquery/docs/snippets.py
Line 487 in 96a1c5b
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 173133642 🦕