Skip to content

Upgrade to Java 11 (round 2)#3165

Merged
dondonz merged 5 commits intomasterfrom
back-to-java-11
Apr 4, 2023
Merged

Upgrade to Java 11 (round 2)#3165
dondonz merged 5 commits intomasterfrom
back-to-java-11

Conversation

@dondonz
Copy link
Member

@dondonz dondonz commented Apr 3, 2023

Our next release will include breaking changes, including upgrading to Java 11!

Upgrading to Java 11 makes it easier to upgrade ANTLR and enables UTF-8 strings.

Note: The 20.1 release was a feature and bugfix release, without any breaking changes. Before the 20.1 release, I had to downgrade back to Java 8 to ensure no breaking changes. See #3110

#
InvalidSyntax.noMessage=Ung\u00fcltige Syntax in Zeile {0} Spalte {1}
InvalidSyntax.full=Ung\u00fcltige Syntax, ANTLR-Fehler ''{0}'' in Zeile {1} Spalte {2}
InvalidSyntax.noMessage=Ung�ltige Syntax in Zeile {0} Spalte {1}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub diff preview doesn't support UTF-8. Shakes fist at ASCII...

I promise you the umlauts are there. On the top right of this file in the diff, click on the ... and then click "View File" to see the full file, umlauts included.

e.g. https://github.com/graphql-java/graphql-java/blob/0428ebb85c38a655a4e4b1d3bfa897bbd48b94b0/src/main/resources/i18n/Parsing_de.properties

Enum.unallowableValue=Literal nicht in den zul\u00e4ssigen Werten f\u00fcr enum ''{0}'' - ''{1}''
Enum.badInput=Ung�ltige Eingabe f�r enum ''{0}''. Unbekannter Wert ''{1}''
Enum.badName=Ung�ltige Eingabe f�r enum ''{0}''. Kein Wert f�r den Namen ''{1}'' gefunden
Enum.unallowableValue=Literal nicht in den zul�ssigen Werten f�r enum ''{0}'' - ''{1}''
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExecutableDefinitions.notExecutableType=Validierungsfehler ({0}) : Type definition ''{1}'' ist nicht ausf�hrbar
ExecutableDefinitions.notExecutableSchema=Validierungsfehler ({0}) : Schema definition ist nicht ausf�hrbar
ExecutableDefinitions.notExecutableDirective=Validierungsfehler ({0}) : Directive definition ''{1}'' ist nicht ausf�hrbar
ExecutableDefinitions.notExecutableDefinition=Validierungsfehler ({0}) : Die angegebene Definition ist nicht ausf�hrbar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dondonz dondonz added this to the 2023 July milestone Apr 3, 2023
# Conflicts:
#	.github/workflows/master.yml
#	.github/workflows/pull_request.yml
#	.github/workflows/release.yml
@dondonz dondonz added this pull request to the merge queue Apr 4, 2023
Merged via the queue into master with commit 5db842f Apr 4, 2023
@dondonz dondonz deleted the back-to-java-11 branch April 4, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant