Gracefully returning null in cases of UnresolvedTypeException#3122
Merged
bbakerman merged 1 commit intographql-java:masterfrom Mar 18, 2023
Merged
Gracefully returning null in cases of UnresolvedTypeException#3122bbakerman merged 1 commit intographql-java:masterfrom
bbakerman merged 1 commit intographql-java:masterfrom
Conversation
The different code path that existed prior to this change would omit the calls to `onFieldValuesInfo` when an `UnresolvedTypeException` occurred, and that causes a thread leak similar to an older issue for unhandled exceptions graphql-java#2068 - that is, once a type cannot be resolved, the deeper batches from other (successful) branches are never dispatched. Since we are just adding an error in the cases of `UnresolvedTypeException` and try to set the value to null, this only needed a small refactoring to make it similar to when the value is actually null.
bbakerman
approved these changes
Mar 18, 2023
| private FieldValueInfo getFieldValueInfoForNull(ExecutionContext executionContext, ExecutionStrategyParameters parameters) { | ||
| CompletableFuture<ExecutionResult> fieldValue = completeValueForNull(executionContext, parameters); | ||
| return FieldValueInfo.newFieldValueInfo(NULL).fieldValue(fieldValue).build(); | ||
| } |
Member
There was a problem hiding this comment.
I had a look at this in the complete code. I can see that the value as not being completed into a CF and hence this would intere with the completion of data loaders and so on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The different code path that existed prior to this change would omit the calls to
onFieldValuesInfowhen anUnresolvedTypeExceptionoccurred, and that causes a thread leak similar to an older issue for unhandled exceptions #2068 - that is, once a type cannot be resolved, the deeper batches from other (successful) branches are never dispatched.Since we are just adding an error in the cases of
UnresolvedTypeExceptionand try to set the value to null, this only needed a small refactoring to make it similar to when the value is actually null.