Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

chore: refactor test utilities#2013

Merged
JoeWang1127 merged 1 commit into
mainfrom
chore/refactor-test-utilities
Sep 20, 2023
Merged

chore: refactor test utilities#2013
JoeWang1127 merged 1 commit into
mainfrom
chore/refactor-test-utilities

Conversation

@JoeWang1127

@JoeWang1127 JoeWang1127 commented Sep 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

In this PR:

  • Move testing utility functions to library_generation/test/test_utilities.sh.

Follow up of #2004 (comment)

@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Sep 20, 2023
JoeWang1127
JoeWang1127 commented Sep 20, 2023
View reviewed changes
Comment thread library_generation/test/generate_library_integration_test.sh
source "${script_dir}/../utilities.sh"
library_generation_dir="${script_dir}"/..
output_folder="$(get_output_folder)"
source "${script_dir}/test_utilities.sh"

@JoeWang1127 JoeWang1127 Sep 20, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now integration test script only source test_utilities.sh

Comment thread showcase/scripts/generate_showcase.sh
mkdir -p "${SCRIPT_DIR}/output"

# takes a versions.txt file and returns its version
get_version_from_versions_txt() {

@JoeWang1127 JoeWang1127 Sep 20, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is only used in generating showcase, so move it here.

@sonarqubecloud

sonarqubecloud Bot commented Sep 20, 2023

Copy link
Copy Markdown

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Sep 20, 2023

Copy link
Copy Markdown

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Sep 20, 2023

Copy link
Copy Markdown

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JoeWang1127
JoeWang1127 marked this pull request as ready for review September 20, 2023 14:23
@JoeWang1127
JoeWang1127 requested review from a team, blakeli0 and diegomarquezp September 20, 2023 14:23
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2023
@JoeWang1127
JoeWang1127 merged commit 1f4aa27 into main Sep 20, 2023
@JoeWang1127
JoeWang1127 deleted the chore/refactor-test-utilities branch September 20, 2023 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp
1 more reviewer
@blakeli0 blakeli0 blakeli0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoeWang1127 @blakeli0