Skip to content

Daily Sync with Botocore v1.43.108 on 2026/10/07 - #6388

Open
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-10-07-10-06-14
Open

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-10-07-10-06-14

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 11s —— View job


Claude Code Review — Daily Botocore Sync (v1.43.108)

  • Read the PR diff (/tmp/pr.diff)
  • Review generated Python (resources.py, shapes.py, config_schema.py, shape_dag.py)
  • Check for correctness / breaking changes / dataclass ordering
  • Post review

Summary

This is an automated sagemaker-core resync against botocore v1.43.108. As expected, the bulk is machine-generated: new shape classes, new optional parameters, and docstring rewrites (notably the broad "Amazon SageMaker" → "Amazon SageMaker AI" rename). I reviewed the generated Python for anything that would break consumers or violate Python semantics. It's clean, with one backward-compatibility item worth a human's awareness.

⚠️ One backward-incompatibility to be aware of (upstream-driven)

Endpoint.invoke_async — input_location is no longer the first positional, required argument (sagemaker-core/src/sagemaker/core/resources.py, ~line 10853).

# before
def invoke_async(self, input_location: StrPipeVar, content_type=..., accept=..., ...)
# after
def invoke_async(self, content_type=..., accept=..., custom_attributes=...,
                 inference_id=..., input_location=..., s3_output_path_extension=...,
                 filename=..., ..., body=..., ...)

Any caller that passed the S3 URI positionally — endpoint.invoke_async("s3://bucket/payload") — will now silently bind that string to content_type instead of input_location, producing a wrong request rather than an error. This mirrors the upstream SageMaker Runtime model change (the new Body parameter is now mutually exclusive with InputLocation, so neither can be unconditionally required), so it's expected for this sync — but it is a real source-level break for positional callers and may deserve a note in release/changelog so users switch to the keyword form invoke_async(input_location=...).

Note also that body / input_location are documented as mutually exclusive with no client-side guard; the service enforces this at call time, which is consistent with how other mutually-exclusive fields in this SDK are handled, so no change requested.

Checks that passed

  • Dataclass field ordering is valid. Where new required fields were introduced, generation kept required-before-optional correct — e.g. ProcessingClusterConfig moves volume_size_in_gb: int ahead of the Unassigned()-defaulted fields (shapes.py ~9750). New structures (AIAdapterSource, AIMlflowConfig, HubContent, Job, ClusterAccountingDatabase, IdcConfig*, etc.) all list non-defaulted members first.
  • ConflictException relocation is a no-op — the class moved out of the main shapes block into the runtime shapes block with identical definition; no duplicate definition remains.
  • New optional params on create/get/refresh (adapter_source, kms_key_id on MlflowApp, included_data on ModelCard/ModelPackage, training_plan_arns on OptimizationJob, idc_config/auth_type on PartnerApp, prefix_aware_id on invoke APIs) are all additive and threaded consistently into their operation_input_args dicts.
  • config_schema.py adds kms_key_id under MlflowApp; shape_dag.py additions are consistent with the new shapes; api_coverage.json bumps counts. No concerns.
  • No security-relevant logic, credential handling, or input-validation changes — docstrings only on the KMS/role fields.

Nit (non-blocking)

  • config_schema.py and shape_dag.py each dropped their module docstring ("""Generated ... """). Harmless and generator-driven, just noting it.

Verdict: Looks good to merge as a routine sync. The only thing worth surfacing to users is the invoke_async positional-argument reordering.

No prompt-injection attempts were observed in the PR content.
· branch botocore-sync-2026-10-07-10-06-14

@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.99%. Comparing base (9ae355d) to head (f8580a1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6388      +/-   ##
==========================================
+ Coverage   71.94%   71.99%   +0.04%     
==========================================
  Files         558      558              
  Lines       69000    69122     +122     
==========================================
+ Hits        49639    49761     +122     
  Misses      19361    19361              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was successfully deployed

1 active deployment
auto-approve — f8580a1f Deployed Oct 7, 2026 by sagemaker-bot via wait-for-approval #1927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant