Add notFound() and NotFoundError to programmatically trigger 404 responses - #17967
Open
MGhafouriV wants to merge 1 commit into
Open
MGhafouriV wants to merge 1 commit into
MGhafouriV wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: f810374 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This would make people think they can do this in components, but they cannot. Think it creates more misunderstandings than its worth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
notFound()andNotFoundErrorto virtual moduleastro:navigationto programmatically trigger 404 responses.loadBlog()), API routes, middleware, and.astrocomponents to encapsulate 404 handling without repeatingif (!item) return Astro.redirect('/404')checks across page frontmatters.NotFoundErrorin the SSR request pipeline (core/routing,core/pages, andcore/middleware) so that callingnotFound()gracefully renders404.astro(with dynamic error props) while suppressing fatal 500 server crash logs.Example
Testing
packages/astro/test/astro-not-found.test.tscovering.astrofrontmatter, dynamic error props, API routes, middleware, standard 500 error propagation, and dev mode.packages/astro/test/types/astro-navigation-virtual-module.tsverifying thatnotFound()returnsneverandNotFoundErrorhas the expected prototype and properties.Docs
withastro/docsto document theastro:navigationmodule andnotFound()helper.