Skip to content

Conversation

@dmart28
Copy link
Contributor

@dmart28 dmart28 commented Jun 9, 2018

Fix for the #727 issue.

@dmart28 dmart28 requested review from bsideup, kiview and rnorth as code owners June 9, 2018 12:11
@rnorth
Copy link
Member

rnorth commented Jun 10, 2018

Potentially overtaken by another PR - reassess after merging #617.

dmart28 added 4 commits June 13, 2018 12:37
# Conflicts:
#	modules/jdbc-test/src/test/java/org/testcontainers/jdbc/JDBCDriverTest.java
#	modules/jdbc/src/main/java/org/testcontainers/jdbc/ContainerDatabaseDriver.java
@kiview
Copy link
Member

kiview commented Jun 22, 2018

@rnorth Just wanted to ping you, since #617 has been merged now. PR LGTM.

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the contribution @dmart28, and sorry it's taken ages to merge.

@rnorth rnorth merged commit 5b4d0ee into testcontainers:master Jul 10, 2018
@rnorth
Copy link
Member

rnorth commented Jul 12, 2018

Released in 1.8.1! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants