Update/nx 23#1919
Open
gestj wants to merge 4 commits into
Open
Conversation
Bumps all @nx/* packages and nx to 23.0.1, Angular to 21.2.9, jest 30, cypress 15.18. Applies 27 nx codemods (nx.json eslint inputs, ignore files, jest-30 snapshot header URLs).
@angular/build 21.2 (Nx 23) loads custom builder `plugins` as native ESM. The plugin was resolved via tsconfig path to the TS source, whose directory/extensionless imports throw ERR_UNSUPPORTED_DIR_IMPORT under native ESM (it only worked before because it loaded as CJS). Point the plugin at the compiled CJS output (dist/libs/rebundle) and add dependsOn ^build so the lib is built first. Generated by Claude claude-opus-4-8[1m]
|
View your CI Pipeline Execution ↗ for commit 66528c5
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
|
@gestj did you use the NX V23.1.0.beta to test the Angular 22 support? I was looking and the official version that will support Angular 22 is NX V23.1.0. |
Contributor
Author
No, I didn't. My approach is always small steps. If NX 23.1.0 is out faster than this MR merged (& it really supports Angular 22), I might redo this thing here. |
added 2 commits
July 7, 2026 12:34
The demo build loads the rebundle plugin from its compiled output (dist/libs/rebundle/src/index.js). Only the `build` target declared `dependsOn: ^build`, so `serve` (dev) and `e2e` (via serve:production) ran without the lib built. On a fresh checkout — and on distributed Nx Cloud agents, where the dist is not replayed unless it is a task-graph dependency — plugin resolution failed with "Cannot find module 'dist/libs/rebundle/src/index.js'", breaking CI e2e. Add the missing build edges: `^build` on serve, `rebundle:build` on e2e. Generated by Claude claude-opus-4-8[1m]
# Conflicts: # yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the workspace to Nx 23.0.1 (from 22.3.3) via
nx migrate— bumps all @nx/* packages, Angular 21.2.9, jest 30, cypress 15.18; runs the 27 codemods (nx.json eslint inputs, ignore-file entries, jest-30 snapshot header URLs).Fix included
rebundle-demo:buildbroke:Directory import '.../libs/rebundle/src/core' is not supported resolving ES modules imported from .../libs/rebundle/src/index.ts@angular/build 21.2 (via Nx 23) now loads custom builder
pluginsas native ESM. The demo resolved@rx-angular/rebundlethrough the tsconfig path to the TS source, whose directory/extensionless imports throwERR_UNSUPPORTED_DIR_IMPORTunder native ESM — it only worked before because the plugin loaded as CommonJS (directoryrequireis valid there).Fix: point the demo plugin entry at the compiled CJS output (
dist/libs/rebundle) +dependsOn: ["^build"]so the lib builds first.Verification (local)
format:check ✅ · lint (12) ✅ · test (58) ✅ · build (12) ✅ · component-test (58) ✅ · e2e rebundle-demo ✅ · docs build ✅