Disconnect if configure_connection failed#54711
Merged
byroot merged 1 commit intorails:mainfrom Mar 7, 2025
Merged
Conversation
Fix: rails#51780 There are a number of scenarios in which one of the queries performed as part of `configure_connection` fails, and leave the `Adapter` in an half initialized state. Up to Rails 7.0, this could likely happen during a call to `reconnect!`, so relatively rare. For the more classic initial connection, the `Adapter` instance would only be added to the pool on a successful connect. But in 7.1 I made the connection fully lazy, meaning the `Adapter` instance is now added to the pool before attempting to connect. This made this bug much more likely. The solution is to disconnect if `configure_connection` raises an error. This way on a retry we'll reconnect and reconfigure from scratch.
byroot
added a commit
that referenced
this pull request
Mar 7, 2025
Disconnect if `configure_connection` failed
byroot
added a commit
that referenced
this pull request
Mar 7, 2025
Disconnect if `configure_connection` failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #51780
There are a number of scenarios in which one of the queries performed as part of
configure_connectionfails, and leave theAdapterin an half initialized state.Up to Rails 7.0, this could likely happen during a call to
reconnect!, so relatively rare. For the more classic initial connection, theAdapterinstance would only be added to the pool on a successful connect.But in 7.1 I made the connection fully lazy, meaning the
Adapterinstance is now added to the pool before attempting to connect.This made this bug much more likely.
The solution is to disconnect if
configure_connectionraises an error. This way on a retry we'll reconnect and reconfigure from scratch.