Skip to content

Limiting the maximum number of tags on Tag.parse_tag() #1220

Description

@facutuesca

Would it be worth adding a limit to the maximum number of tags parsed in Tag.parse_tag()?. It builds the cartesian product of compressed tag components:

for interpreter in interpreters.split("."):
for abi in abis.split("."):
for platform_ in platforms.split("."):
tags.add(Tag(interpreter, abi, platform_))

The spec does warn about it, but doesn't actually specify a limit for them

This compression scheme can generate large numbers of unsupported tags and “impossible” tags that are supported by no Python implementation e.g. “cp33-cp31u-win64”, so use it sparingly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions