Make trailing comma logic more consise - #4202
Merged
Merged
Conversation
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
cobaltt7
marked this pull request as draft
February 1, 2024 16:39
cobaltt7
marked this pull request as ready for review
February 1, 2024 16:56
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
hauntsaninja
approved these changes
Feb 6, 2024
hauntsaninja
approved these changes
Feb 28, 2024
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
Thank you again! :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplified the logic for adding trailing commas. Turned out it was actually a bit simpler than I thought.
See #4164 (comment)
Checklist - did you ...
CHANGES.mdif necessary?