pre-push: fix stdin line splitting when <local ref> has whitespace - #2345
Merged
Conversation
From the `pre-push.sample` file: > Information about the commits which are being pushed is supplied as > lines to the standard input in the form: > > <local ref> <local sha1> <remote ref> <remote sha1> When `<local ref>` is not simply a branch name, but a more general ref (see git-rev-parse(1)), it could contain whitespace, and that breaks the split() call that expected only 3 spaces in the line. Changed to use `rsplit(maxsplit=3)` since only the <local ref> is likely to have embedded whitespace. Added a new test case for the same.
asottile
approved these changes
Apr 14, 2022
asottile
left a comment
Member
There was a problem hiding this comment.
nice, you learn something wild and wacky about git every day it seems
Contributor
Author
at least every day 😄 also, I love this gif, thanks for that! |
Member
|
heh -- there's a bunch more and a user script too -- https://github.com/chriskuehl/shipit https://www.youtube.com/watch?v=2rDNJvHznrM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the
pre-push.samplefile:When
<local ref>is not simply a branch name, but a more generalref (see git-rev-parse(1)), it could contain whitespace, and that
breaks the split() call that expected only 3 spaces in the line.
Changed to use
rsplit(maxsplit=3)since only the islikely to have embedded whitespace.
Added a new test case for the same.
Fixes #2344