Skip to content

Use 'go install' instead of 'go get' - #2161

Merged
asottile merged 1 commit into
pre-commit:masterfrom
schmir:use-go-install
Dec 15, 2021
Merged

Use 'go install' instead of 'go get'#2161
asottile merged 1 commit into
pre-commit:masterfrom
schmir:use-go-install

Conversation

@schmir

@schmir schmir commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

go install is the recommended way to install modules starting from go 1.16.
In go 1.18 go get cannot be used anymore to install packages [1]. go 1.18 is
not released yet.

[1] https://tip.golang.org/doc/go1.18#go-command

`go install` is the recommended way to install modules starting from go 1.16.
In go 1.18 `go get` cannot be used anymore to install packages [1]. go 1.18 is
not released yet.

[1] https://tip.golang.org/doc/go1.18#go-command

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well that's quite annoying -- this will probably break old versions of go but we don't really have a choice

@asottile
asottile merged commit c0d3b8e into pre-commit:master Dec 15, 2021
@casperdcl

Copy link
Copy Markdown

yes just broke for me on GH actions default go version. Any plans to support language_version for language: golang?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants