Short-circuit ByteBuf::release #13782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This just remove the
Despite being a tiny amount, overall, in the global picture, for the write/flush path, is still an unecessary cost, see
where the |
Contributor
|
In these scenarios, I really love pattern-type matches. |
transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java
Outdated
Show resolved
Hide resolved
Motivation: ReferenceCountUtil::safeRelease can both hit interface virtual calls and requires checking for an interface type (ReferenceCounted) Modifications: Perform a class check to save both. Result: Faster buffers release
654253b to
49952a6
Compare
chrisvest
approved these changes
Jan 18, 2024
franz1981
added a commit
to franz1981/netty
that referenced
this pull request
Feb 9, 2024
Motivation: ReferenceCountUtil::safeRelease can both hit interface virtual calls and requires checking for an interface type (ReferenceCounted) Modifications: Perform a class check to save both. Result: Faster buffers release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ReferenceCountUtil::safeRelease can both hit interface virtual calls and requires checking for an interface type (ReferenceCounted)
Modifications:
Perform a class check to save both.
Result:
Faster buffers release