Add check for JAVA8_HOME to release script #13725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This environment variable is required. If it's not set, the Netty release will end up being built wrong bytecode version and incompatible ABI. Modification: Add a check that the JAVA8_HOME environment variable does not resolve to the empty string. Result: We're less likely to get a broken release from mistakes in the manual steps.
Contributor
|
Is it a precaution or damage has been done already? |
normanmaurer
approved these changes
Dec 13, 2023
Member
Author
|
@hyperxpro This caused the 4.1.102 release to get messed up. |
Contributor
|
Heck, we should have an ABI check before the final release to Central. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This environment variable is required.
If it's not set, the Netty release will end up being built with wrong bytecode version and incompatible ABI.
Modification:
Add a check that the JAVA8_HOME environment variable does not resolve to the empty string.
Result:
We're less likely to get a broken release from mistakes in the manual steps.