Skip to content

Add one more unit-test case for invalid email domains in the Autolinker class - #21392

Merged
calixteman merged 1 commit into
mozilla:masterfrom
Snuffleupagus:Autolinker-invalid-email-domain-test
Jun 6, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
Snuffleupagus:Autolinker-invalid-email-domain-test

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

This improves coverage for a branch of the Autolinker class that wasn't previously tested.

…ker` class

This improves coverage for a branch of the `Autolinker` class that wasn't previously tested.
@Snuffleupagus
Snuffleupagus force-pushed the Autolinker-invalid-email-domain-test branch from badcfe4 to 08b704d Compare June 6, 2026 09:57
@Snuffleupagus Snuffleupagus changed the title Add one more unit-test case for invalid email domains the Autolinker Add one more unit-test case for invalid email domains in the Autolinker class Jun 6, 2026
@codecov-commenter

codecov-commenter commented Jun 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (9c437e6) to head (08b704d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21392      +/-   ##
==========================================
- Coverage   89.55%   89.55%   -0.01%     
==========================================
  Files         260      260              
  Lines       66019    66019              
==========================================
- Hits        59124    59123       -1     
- Misses       6895     6896       +1     
Flag Coverage Δ
unittest 57.11% <ø> (-0.01%) ⬇️
unittestcli 56.07% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman
calixteman merged commit 2348365 into mozilla:master Jun 6, 2026
14 checks passed
@Snuffleupagus
Snuffleupagus deleted the Autolinker-invalid-email-domain-test branch June 6, 2026 12:33

This branch was previously deployed

1 inactive deployment
code-coverage — 08b704d4 Deployed Jun 6, 2026 by Snuffleupagus via Test (24) #15910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants