Repository navigation
Disable WebGPU for Firefox tests - #21364
Merged
Merged
Conversation
The GitHub Actions workflow for the integration tests on Windows logs the following line for every test: `JavaScript warning: http://127.0.0.1:62313/build/generic/build/pdf.mjs, line 134934: WebGPU is disabled by blocklist.` On Linux WebGPU is disabled by default because of missing support, but on Windows it's enabled by default since bug 1972486, so we try to obtain a GPU adapter which fails (and logs) if there is no actual GPU like on GitHub Actions. Coverage data confirms that our own WebGPU code is already uncovered because of the lack of a GPU, so having WebGPU enabled or disabled doesn't change that, but if it causes log spam it seems better to disable it, which this commit does. Note that Chrome doesn't seem to have a matching flag, but Chrome already doesn't log anything about this (which is the primary driver for this change), so that's not a problem.
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with 
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 17:32 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21364 +/- ##
==========================================
- Coverage 81.45% 81.45% -0.01%
==========================================
Files 260 260
Lines 65817 65817
==========================================
- Hits 53611 53608 -3
- Misses 12206 12209 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub Actions workflow for the integration tests on Windows logs the following line for every test:
JavaScript warning: http://127.0.0.1:62313/build/generic/build/pdf.mjs, line 134934: WebGPU is disabled by blocklist.On Linux WebGPU is disabled by default because of missing support, but on Windows it's enabled by default since bug 1972486, so we try to obtain a GPU adapter which fails (and logs) if there is no actual GPU like on GitHub Actions. Coverage data confirms that our own WebGPU code is already uncovered because of the lack of a GPU, so having WebGPU enabled or disabled doesn't change that, but if it causes log spam it seems better to disable it, which this commit does.
Note that Chrome doesn't seem to have a matching flag, but Chrome already doesn't log anything about this (which is the primary driver for this change), so that's not a problem.