Skip to content

Commit 39ff6ff

Browse files
bashmishbashmish
committed
fix: replace ip dependency due to security bug CVE-2024-29415 
1 parent c4a1044 commit 39ff6ff

11 files changed

Lines changed: 254 additions & 35 deletions

File tree

‎.changeset/lemon-suns-sneeze.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
'@web/test-runner-browserstack': patch
3+
'@web/test-runner-saucelabs': patch
4+
'@web/test-runner-core': patch
5+
'@web/dev-server': patch
6+
---
7+
8+
replace ip dependency due to security bug CVE-2024-29415

‎package-lock.json‎

Lines changed: 225 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/dev-server/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"command-line-usage": "^7.0.1",
6666
"debounce": "^1.2.0",
6767
"deepmerge": "^4.2.2",
68-
"ip": "^2.0.1",
68+
"internal-ip": "^6.2.0",
6969
"nanocolors": "^0.2.1",
7070
"open": "^8.0.2",
7171
"portfinder": "^1.0.32"

‎packages/dev-server/src/logger/logStartMessage.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import { DevServerConfig } from '../config/DevServerConfig';
22
import { Logger } from '@web/dev-server-core';
3-
import ip from 'ip';
3+
import internalIp from 'internal-ip';
44
import { bold, cyan, white } from 'nanocolors';
55

66
const createAddress = (config: DevServerConfig, host: string, path: string) =>
77
`http${config.http2 ? 's' : ''}://${host}:${config.port}${path}`;
88

99
function logNetworkAddress(config: DevServerConfig, logger: Logger, openPath: string) {
1010
try {
11-
const address = ip.address();
11+
const address = internalIp.v4.sync();
1212
if (typeof address === 'string') {
1313
logger.log(`${white('Network:')} ${cyan(createAddress(config, address, openPath))}`);
1414
}

‎packages/test-runner-browserstack/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"dependencies": {
4949
"@web/test-runner-webdriver": "^0.8.0",
5050
"browserstack-local": "^1.4.8",
51-
"ip": "^2.0.1",
51+
"internal-ip": "^6.2.0",
5252
"nanoid": "^3.1.25"
5353
},
5454
"devDependencies": {

0 commit comments

Comments
 (0)