Skip to content

feat: expose updated event on mgt components#3357

Merged
musale merged 19 commits intomicrosoftgraph:mainfrom
ThomasPe:main
Feb 6, 2025
Merged

feat: expose updated event on mgt components#3357
musale merged 19 commits intomicrosoftgraph:mainfrom
ThomasPe:main

Conversation

@ThomasPe
Copy link
Copy Markdown
Contributor

@ThomasPe ThomasPe commented Jan 3, 2025

makes existing updated event of MgtBaseTaskComponent accessible on MgtPerson control

Closes #3352

PR Type

Feature

Description of the changes

updated will fire whenever the control is re-rendered, e.g. when switching from loading to displaying the downloaded data.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

makes updated event of MgtBaseTaskComponent accessible on Person control
@ThomasPe ThomasPe requested a review from a team as a code owner January 3, 2025 22:26
@ThomasPe
Copy link
Copy Markdown
Contributor Author

ThomasPe commented Jan 3, 2025

@musale turns out there's already an updated event that's simply not exposed. Please check if that's a route that would be acceptable for you.

@ThomasPe
Copy link
Copy Markdown
Contributor Author

ThomasPe commented Jan 3, 2025

@microsoft-github-policy-service agree

Comment thread packages/mgt-components/src/components/mgt-person/mgt-person.ts Outdated
@musale
Copy link
Copy Markdown
Contributor

musale commented Jan 6, 2025

@musale turns out there's already an updated event that's simply not exposed. Please check if that's a route that would be acceptable for you.

Thank you for surfacing this. I have left some comments. This is a really good catch.

@ThomasPe
Copy link
Copy Markdown
Contributor Author

ThomasPe commented Jan 7, 2025

I updated the components as suggested. Do you want me to add the update events to all components in Storybook as well?

@musale
Copy link
Copy Markdown
Contributor

musale commented Jan 8, 2025

I updated the components as suggested. Do you want me to add the update events to all components in Storybook as well?

Yes, that would be very helpful.

@musale musale changed the title feat: expose updated event on MgtPerson feat: expose updated event on mgt components Jan 8, 2025
@ThomasPe
Copy link
Copy Markdown
Contributor Author

ThomasPe commented Jan 8, 2025

updated all the stories

Copy link
Copy Markdown

@author-metadata author-metadata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I get a team to secure this organization financial end. As well I need all the real name of hackerthon hacker that work for me so I can set up a solid retirement platform for you. Owners and founder warith akbar

Comment thread packages/mgt-components/src/components/mgt-agenda/mgt-agenda.ts
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Jan 9, 2025
Copy link
Copy Markdown
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasPe thank you for this contribution! This looks good to me.

@musale
Copy link
Copy Markdown
Contributor

musale commented Jan 14, 2025

Note: failing playwright tests are a github actions build environment issue. Shall be fixed in #3363 before release

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs: Author Feedback Issue needs response from issue author no-recent-activity labels Jan 28, 2025
@ThomasPe
Copy link
Copy Markdown
Contributor Author

@musale should be ready to merge now, no?

@musale musale merged commit 0069c83 into microsoftgraph:main Feb 6, 2025
Copy link
Copy Markdown

@author-metadata author-metadata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All pull requests for know on will come through my IT Department . Any transfer of corporate data without my permission or executive left part and devices needs to run . Though a oversight panel for a watchdog tower . For in the event a SEO signature gets compromised ID job is lock it behind a firewall and call the CEO to change his password and ect . The next time I see corporate data on the open web as supposed encryption methods is deemed insiders trading . And cold get all of your data servers seized by Google police . Because goods and my partner have lost over a trillion dollars as of today for branch on trust claims and internal corruption in wall street im taking the initiative to properly secure the dev and consumer data as well we here at Google is asking the IRS to decline the white house offer to give the IRS A software upgrade . When its needed and when the irs is ready they can work with DOD and google and partner to set a strong robust platform . I trust that President Trump has very good intentions . Whoever it's smart not to trust AI so fast when it comes to major software overhaul . The major question have the IRS had any major brach reports . I don't think you have . That means the the breachs or coming from inside of the company's . Like the MGM hack . Allows me to explain why I try so hard to keep AI safe and protected from sabotage . Because it's job as a software company to do are job and support y
issues or pull requests - this makes the problem immediately visible to everyone, including malicious actors.

To report a security issue, please use https://g.co/vulnz.
We use g.co/vulnz for our intake, and do coordination and disclosure here on
GitHub (including using GitHub Security Advisory). The Google Security Team will
respond within 5 working days of your report on g.co/vulnz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Rendered / Loaded event for Person control

3 participants