Fix "Could not load file or assembly 'Microsoft.Testing.Platform'" exception#4537
Merged
Conversation
Evangelink
commented
Jan 7, 2025
Youssef1313
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the investigation, I realized that VSTest custom assembly resolver, enabled only when AppDomains are enabled and only for netfx, includes only VS folders and MSTest.TestAdapter. On 3.7, we started to depend upon some types from MTP leading to the dll being required but not loaded in this mode (the deps is part of a different NuGet).
As part of the analysis, I have also noticed that we are required to keep the framework under the adapter folder for the exact same reason.
I have restored the framework, only for netfx, that will be resolved only when under the customer resolver for netfx in VSTest. For MTP, I have decided not to copy the dll but instead to have wrapper types so we don't "pollute" the engine with types specific to a given platform.
Fixes #4426