[Fix] extensions: ignore type-only imports - #2270
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2270 +/- ##
==========================================
- Coverage 94.63% 94.60% -0.04%
==========================================
Files 65 65
Lines 2686 2688 +2
Branches 888 888
==========================================
+ Hits 2542 2543 +1
- Misses 144 145 +1
Continue to review full report at Codecov.
|
ljharb
approved these changes
Oct 23, 2021
ljharb
left a comment
Member
There was a problem hiding this comment.
This fix looks good, but the issue it's fixing is about the import/no-unresolved rule
ljharb
force-pushed
the
patch-6
branch
2 times, most recently
from
October 24, 2021 15:53
3a0c730 to
46c4709
Compare
Contributor
Author
|
Thanks! My reading of #2267 is that the original |
Member
|
hm, maybe so - i'll confirm with the OP. |
glasser
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jun 24, 2022
So, Node requires generated ESM JS files need to have imports that end with `.js` (unless they are importing the root or declared export from a package... but for relative paths, this is a must). But we haven't quite figured out a way to get tsc to force us to do this... so if we mess it up, we only find out at runtime when trying to run a built ESM package. This doesn't even necessarily show up in our tests (Jest does its own thing a lot), and the new smoke-test doesn't cover all of our codebase. So we set up eslint with a particular rule that looks for this. As it happens, this rule doesn't check `import type` (import-js/eslint-plugin-import#2270) but fortunately `import type` doesn't matter to Node. We don't generally enable eslint: there are plenty of rules that we don't pass currently. We can consider adding some rules later as they are found to be valuable. For now we just run this one rule!
glasser
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jun 24, 2022
So, Node requires generated ESM JS files need to have imports that end with `.js` (unless they are importing the root or declared export from a package... but for relative paths, this is a must). But we haven't quite figured out a way to get tsc to force us to do this... so if we mess it up, we only find out at runtime when trying to run a built ESM package. This doesn't even necessarily show up in our tests (Jest does its own thing a lot), and the new smoke-test doesn't cover all of our codebase. So we set up eslint with a particular rule that looks for this. As it happens, this rule doesn't check `import type` (import-js/eslint-plugin-import#2270) but fortunately `import type` doesn't matter to Node. We don't generally enable eslint: there are plenty of rules that we don't pass currently. We can consider adding some rules later as they are found to be valuable. For now we just run this one rule!
glasser
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jun 24, 2022
So, Node requires generated ESM JS files need to have imports that end with `.js` (unless they are importing the root or declared export from a package... but for relative paths, this is a must). But we haven't quite figured out a way to get tsc to force us to do this... so if we mess it up, we only find out at runtime when trying to run a built ESM package. This doesn't even necessarily show up in our tests (Jest does its own thing a lot), and the new smoke-test doesn't cover all of our codebase. So we set up eslint with a particular rule that looks for this. As it happens, this rule doesn't check `import type` (import-js/eslint-plugin-import#2270) but fortunately `import type` doesn't matter to Node. We don't generally enable eslint: there are plenty of rules that we don't pass currently. We can consider adding some rules later as they are found to be valuable. For now we just run this one rule!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import/extensionsrule currently errors on unresolved imports (I gather)∴ disable
import/extensionsfor type-only imports, along the lines of #2220.Relates to #2267