[http2] Dont drop connections on metadata limit exceeded#32309
Merged
ctiller merged 4 commits intogrpc:masterfrom Feb 7, 2023
Merged
[http2] Dont drop connections on metadata limit exceeded#32309ctiller merged 4 commits intogrpc:masterfrom
ctiller merged 4 commits intogrpc:masterfrom
Conversation
yashykt
reviewed
Feb 7, 2023
| grpc_call_unref(s); | ||
|
|
||
| grpc_slice_unref(meta.value); | ||
| } |
Member
There was a problem hiding this comment.
maybe also do a ping to make sure that the channel is still connected?
yashykt
approved these changes
Feb 7, 2023
soheilhy
approved these changes
Feb 7, 2023
Automated fix for refs/heads/repeated_large_metadata
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
* [http] Dont drop connections on metadata limit exceeded * remove bad test * Automated change: Fix sanity tests --------- Co-authored-by: ctiller <ctiller@users.noreply.github.com>
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
* [http] Dont drop connections on metadata limit exceeded * remove bad test * Automated change: Fix sanity tests --------- Co-authored-by: ctiller <ctiller@users.noreply.github.com>
This was referenced Jun 9, 2023
This was referenced Jun 11, 2023
This was referenced Feb 6, 2026
Open
This was referenced Feb 6, 2026
Open
Open
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we get an error on a stream, all we need to do is cancel that stream.
If instead we get an error not associated with a stream, we should close the transport.
Current behavior was to just close the transport always, and this was a bad bug.