avoid allocating in hasDirective#4026
Closed
xuorig wants to merge 1 commit intographql-java:masterfrom
Closed
Conversation
Member
|
Ahh I can see why we are in efficient - in the interfaces we tried to save "code" by making a default method do the work But interfaces cant have state so this should have been done once on construction but rather now its done per call |
bbakerman
approved these changes
Jun 27, 2025
Member
|
Again while I think this mostly fixes the issue I thought I would do a more systemic PR that made sure all the DirectivesContainer methods are more memory efficient. I think this is better since the other methods beyond |
Author
|
Closing in favor of #4027, thanks @bbakerman ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hasDirectiveonDirectivesContainersounds cheap but actually allocates/copies/does a groupingBy on every call. There is no need to group by in this case, and we can cheaply iterate overgetDirectivesinstead, which does not copy/allocate anything.