Skip to content

ensure DFEImpl graphql context is never null #4004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andimarek merged 1 commit into from
Jun 6, 2025
Merged

ensure DFEImpl graphql context is never null #4004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/graphql/schema/DataFetchingEnvironmentImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@


import com.google.common.collect.ImmutableMap;
import graphql.Assert;
import graphql.GraphQLContext;
import graphql.Internal;
import graphql.collect.ImmutableKit;
Expand Down Expand Up @@ -60,7 +61,7 @@ private DataFetchingEnvironmentImpl(Builder builder) {
this.source = builder.source;
this.arguments = builder.arguments == null ? ImmutableKit::emptyMap : builder.arguments;
this.context = builder.context;
this.graphQLContext = builder.graphQLContext;
this.graphQLContext = Assert.assertNotNull(builder.graphQLContext);
this.localContext = builder.localContext;
this.root = builder.root;
this.fieldDefinition = builder.fieldDefinition;
Expand Down Expand Up @@ -266,7 +267,7 @@ public static class Builder {

private Object source;
private Object context;
private GraphQLContext graphQLContext;
private GraphQLContext graphQLContext = GraphQLContext.newContext().build();
private Object localContext;
private Object root;
private GraphQLFieldDefinition fieldDefinition;
Expand Down