Add setting to change time before a repeat is allowed in continuous radio mode - #1630
Conversation
|
I will rebase later if this doesn't work, it anyway needed conflict resolution |
f0a5128 to
90c1aca
Compare
|
idk why all of sudden it affected splash screen but anyway |
|
Conflicted, will resolve conflicts later; I guess it needs reimplementation |
|
Just for reference, here's how this looks in Music Assistant: One thing in general: we might need to change the position if it's not available for all radio modes. It could go right below the continuous mode? But maybe it would be useful to have this repetition stuff for all modes (although it goes somewhat against the "Random" mode) |
|
Either way, we should probably not use 0 for disabled here. Is someone has short tracks (e.g. 30s), that would prevent true randomness. Some kind of toggle or mode selector is probably clearer and less technical? |
Changes
A picture is worth a thousand words
Add "Allow repeats after" setting in radio menu, visible only when continuous mode is selected (currently appears without any animation), with 90 used as default but set to 5 on screenshot. If field is empty but submitted, it resets to 0, disabling repetition entirely and thus fixing #1610.
I should say that, since I don't know flutter well, I decided to slow things down and run OpenCode+gemma4-26b/llama.cpp+superpowers to write UI code (the latter commit, positive branch of
ifstatement only; that plugin was simply installed, listed for completeness). Since resulting UI was very poor, I added leading icon much like ChoiceMenuOption, fixed onSubmitted to reset to 0 on invalid submit and split title to title and subtitle. I say it's 50/50 and I checked it with other code so it looks good to me.It might be a good idea to extract this option into reusable widget, but it's currently used in choice list so idk, it's definitely not a choice
It looks strange since there is some delay between mode selection and sheet closure (remove the delay?), however my idea, I think, has some point:
I almost said i can't test it but I finally found it (1 minute is used):
You just need an artist so unique it doesn't find anything closer than his other tracks
Great album btw. Calming.
Alternatives
Todo before merging
Related Issues
Fixes #1610