Skip to content

refactor: add missing options for timers on config.ts file - #10632

Merged
SimenB merged 3 commits into
jestjs:masterfrom
ftonato:refactor/types-config
Oct 14, 2020
Merged

refactor: add missing options for timers on config.ts file#10632
SimenB merged 3 commits into
jestjs:masterfrom
ftonato:refactor/types-config

Conversation

@ftonato

@ftonato ftonato commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

Summary

@jest/types config in Config.ts has missing value(s) for timers in two variables InitialOptions and DefaultOptions.


Closes #10609

@jeysal jeysal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Comment thread packages/jest-types/src/Config.ts Outdated

@SimenB SimenB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add an entry to the changelog as well?

@ftonato

ftonato commented Oct 14, 2020

Copy link
Copy Markdown
Contributor Author

Yes, I will do it!

@SimenB
SimenB merged commit e84a70c into jestjs:master Oct 14, 2020
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@jest/types config is missing timers option

4 participants