docs: correct fieldNameSize default in limits table - #1432
Merged
Merged
Conversation
The runtime does not enforce a 100-byte default; the check in lib/make-middleware.js is gated behind Object.prototype.hasOwnProperty.call(limits, 'fieldNameSize'). Aligning docs with actual behavior.
|
coverage: 99.01%. remained the same — docs/limits-defaults-h696 into main |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.md:277documentsfieldNameSizeas defaulting to100 bytes, but the runtime does not enforce that default.lib/make-middleware.jsonly checksfieldNameSizewhen the developer explicitly passes it vialimits, gated behindObject.prototype.hasOwnProperty.call(limits, 'fieldNameSize').Correcting the table to say
Infinitymatches the shape of adjacent unenforced-limit rows (fields,parts,fieldNestingDepth) and reflects actual multer runtime behavior. Developers who want a bound must setlimits.fieldNameSizeexplicitly.A separate PR against
v3will add a real enforced default as a breaking change for the next major release.