Skip to content

docs: fix Chinese README translation - #1429

Merged
UlisesGascon merged 1 commit into
expressjs:mainfrom
vibhor-aggr:docs/fix-zh-readme-translation
Aug 24, 2026
Merged

UlisesGascon merged 1 commit into
expressjs:mainfrom
vibhor-aggr:docs/fix-zh-readme-translation

Conversation

@vibhor-aggr

Copy link
Copy Markdown
Contributor

Summary

Closes #576.

Fixes two mistranslated passages in the Chinese README:

  • Clarifies that callers must create the directory when destination is a function, while Multer creates it when destination is a string.
  • Clarifies that req and file are the two inputs passed to the storage callbacks to help make the decision.

Verification

PATH=/mnt/TBT_DATA/nipun/work/tasks/earn-100-legal/workspace/toolchains/node/node-v24.16.0-linux-x64/bin:$PATH npm run lint
PATH=/mnt/TBT_DATA/nipun/work/tasks/earn-100-legal/workspace/toolchains/node/node-v24.16.0-linux-x64/bin:$PATH npm test
git diff --check

Results: lint passed, full test suite passed with 80 passing tests, and diff check passed.

@UlisesGascon UlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vibhor-aggr!

@UlisesGascon
UlisesGascon merged commit b5e0bd8 into expressjs:main Aug 24, 2026
2 checks passed
@UlisesGascon UlisesGascon self-assigned this Aug 24, 2026
@UlisesGascon UlisesGascon mentioned this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Find two mistakes in the Chinese version README file

2 participants