feat: report max-nested-callbacks violations at function head#20967
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
approved these changes
Jun 10, 2026
mdjermanovic
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! Since this is a feat, leaving it open for a second review.
Marking as accepted since this change is consistent with the change we recently made in the complexity rule (#20048).
John4064
pushed a commit
to Doble-Technologies/MatchingMakingWebsite
that referenced
this pull request
Jun 21, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`10.4.1` → `10.5.0`](https://renovatebot.com/diffs/npm/eslint/10.4.1/10.5.0) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v10.5.0`](https://github.com/eslint/eslint/releases/tag/v10.5.0) [Compare Source](eslint/eslint@v10.4.1...v10.5.0) #### Features - [`5ca8c52`](eslint/eslint@5ca8c52) feat: correct stack tracking in max-nested-callbacks ([#​20973](eslint/eslint#20973)) (Pixel998) - [`b565783`](eslint/eslint@b565783) feat: report no-with violations at the with keyword ([#​20971](eslint/eslint#20971)) (Pixel998) - [`2ce032f`](eslint/eslint@2ce032f) feat: report max-lines-per-function violations at function head ([#​20966](eslint/eslint#20966)) (Pixel998) - [`732cb3e`](eslint/eslint@732cb3e) feat: report max-nested-callbacks violations at function head ([#​20967](eslint/eslint#20967)) (Pixel998) - [`f9c138a`](eslint/eslint@f9c138a) feat: report max-depth violations on keywords ([#​20943](eslint/eslint#20943)) (Pixel998) - [`bdb496c`](eslint/eslint@bdb496c) feat: correct max-depth handling for else-if chains ([#​20944](eslint/eslint#20944)) (Pixel998) - [`c296873`](eslint/eslint@c296873) feat: update error loc in `max-statements` to function header ([#​20907](eslint/eslint#20907)) (Taejin Kim) #### Documentation - [`8ae1b5b`](eslint/eslint@8ae1b5b) docs: Update README (GitHub Actions Bot) - [`ca7eb90`](eslint/eslint@ca7eb90) docs: update Node.js prerequisites to include ICU support ([#​20962](eslint/eslint#20962)) (Francesco Trotta) - [`f99b47a`](eslint/eslint@f99b47a) docs: Update README (GitHub Actions Bot) - [`acf03d4`](eslint/eslint@acf03d4) docs: clarify precedence of parserOptions over languageOptions ([#​20926](eslint/eslint#20926)) (sethamus) #### Chores - [`b18bf58`](eslint/eslint@b18bf58) chore: update ecosystem plugins ([#​20959](eslint/eslint#20959)) (ESLint Bot) - [`c2d1444`](eslint/eslint@c2d1444) refactor: replace areAllSegmentsUnreachable with !isAnySegmentReachable ([#​20951](eslint/eslint#20951)) (Taejin Kim) - [`243b8c5`](eslint/eslint@243b8c5) chore: enhance config-rule to support oneOf, anyOf, and nested schemas ([#​20788](eslint/eslint#20788)) (kuldeep kumar) - [`217b2a9`](eslint/eslint@217b2a9) test: add unit tests for ParserService ([#​20949](eslint/eslint#20949)) (Taejin Kim) - [`72003e7`](eslint/eslint@72003e7) test: add location information to error messages in `max-statements` ([#​20945](eslint/eslint#20945)) (lumir) - [`7797c26`](eslint/eslint@7797c26) refactor: deduplicate isAnySegmentReachable across rules ([#​20890](eslint/eslint#20890)) (Taejin Kim) - [`67c46fa`](eslint/eslint@67c46fa) chore: update ecosystem plugins ([#​20938](eslint/eslint#20938)) (ESLint Bot) - [`95d8c7a`](eslint/eslint@95d8c7a) chore: update dependency [@​eslint/json](https://github.com/eslint/json) to v2 ([#​20934](eslint/eslint#20934)) (renovate\[bot]) - [`cf9e496`](eslint/eslint@cf9e496) chore: update [@​arethetypeswrong/cli](https://github.com/arethetypeswrong/cli) to 0.18.3 ([#​20933](eslint/eslint#20933)) (Pixel998) - [`fb6d396`](eslint/eslint@fb6d396) test: run type tests with TypeScript 7 ([#​20868](eslint/eslint#20868)) (sethamus) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMzMuNCIsInVwZGF0ZWRJblZlciI6IjQzLjIzMy40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: Renovate Bot <renovate@git.rcslabs.dev> Reviewed-on: https://git.rcslabs.dev/Doble/MatchingMakingSite/pulls/44 Reviewed-by: mattdimegs <mdimeglio34@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
max-nested-callbackslimits how deeply callbacks can be nested. When the rule reports a violation, highlighting the entire callback can be noisy, especially when the callback body is large.What changes did you make? (Give an overview)
Updated
max-nested-callbacksso violations are reported on the function head instead of the full callback node.Is there anything you'd like reviewers to focus on?